fix; dont flatten empty arrays in updateValidators (Fix #3554)

vkarpov15 · vkarpov15 · commit 68e394d9c1bb · 2015-11-09T13:32:42.000-05:00
diff --git a/lib/services/updateValidators.js b/lib/services/updateValidators.js
@@ -159,7 +159,6 @@ function modifiedPaths(update, path, result) {
     var val = update[key];
 
     result[path + key] = true;
-
     if (shouldFlatten(val)) {
       modifiedPaths(val, path + key, result);
     }
@@ -194,5 +193,6 @@ function shouldFlatten(val) {
   return val &&
     typeof val === 'object' &&
     !(val instanceof Date) &&
-    !(val instanceof ObjectId);
+    !(val instanceof ObjectId) &&
+    (!Array.isArray(val) || val.length > 0);
 }

Original file line number	Diff line number	Diff line change
`@@ -159,7 +159,6 @@ function modifiedPaths(update, path, result) {`
`159`	`159`	`var val = update[key];`
`160`	`160`
`161`	`161`	`result[path + key] = true;`
`162`		`-`
`163`	`162`	`if (shouldFlatten(val)) {`
`164`	`163`	`modifiedPaths(val, path + key, result);`
`165`	`164`	`}`
`@@ -194,5 +193,6 @@ function shouldFlatten(val) {`
`194`	`193`	`return val &&`
`195`	`194`	`typeof val === 'object' &&`
`196`	`195`	`!(val instanceof Date) &&`
`197`		`- !(val instanceof ObjectId);`
	`196`	`+ !(val instanceof ObjectId) &&`
	`197`	`+ (!Array.isArray(val) \|\| val.length > 0);`
`198`	`198`	`}`