Fixes #10072

Automattic · Mar 29, 2021 · 452c77c · 452c77c
1 parent 9e98cd8
commit 452c77c
Show file tree

Hide file tree

Showing 2 changed files with 25 additions and 2 deletions.
diff --git a/index.d.ts b/index.d.ts
@@ -1166,8 +1166,8 @@ declare module 'mongoose' {
     pre<T extends Query<any, any> = Query<any, any>>(method: MongooseQueryMiddleware | MongooseQueryMiddleware[] | string | RegExp, options: SchemaPreOptions, fn: (this: T, next: (err: CallbackError) => void) => void): this;
     pre<T extends Aggregate<any> = Aggregate<any>>(method: 'aggregate' | RegExp, fn: (this: T, next: (err: CallbackError) => void) => void): this;
     pre<T extends Aggregate<any> = Aggregate<any>>(method: 'aggregate' | RegExp, options: SchemaPreOptions, fn: (this: T, next: (err: CallbackError) => void) => void): this;
-    pre<T extends Model<DocType> = M>(method: 'insertMany' | RegExp, fn: (this: T, next: (err: CallbackError) => void) => void): this;
-    pre<T extends Model<DocType> = M>(method: 'insertMany' | RegExp, options: SchemaPreOptions, fn: (this: T, next: (err: CallbackError) => void) => void): this;
+    pre<T extends Model<DocType> = M>(method: 'insertMany' | RegExp, fn: (this: T, next: (err?: CallbackError) => void, docs: any | Array<any>) => void): this;
+    pre<T extends Model<DocType> = M>(method: 'insertMany' | RegExp, options: SchemaPreOptions, fn: (this: T, next: (err?: CallbackError) => void, docs: any | Array<any>) => void): this;
 
     /** Object of currently defined query helpers on this schema. */
     query: { [name: string]: <T extends QueryWithHelpers<any, DocType, ExtractQueryHelpers<M>> = QueryWithHelpers<any, DocType, ExtractQueryHelpers<M>>>(this: T, ...args: any[]) => any };

diff --git a/test/typescript/middleware.ts b/test/typescript/middleware.ts
@@ -39,4 +39,27 @@ schema.post<ITest>('save', function(err: Error, res: ITest, next: Function) {
   console.log(this.name, err.stack);
 });
 
+schema.pre<Model<ITest>>('insertMany', function() {
+  return Promise.resolve(this.name);
+});
+
+schema.pre<Model<ITest>>('insertMany', { document: false, query: false }, function() {
+  console.log(this.name);
+});
+
+schema.pre<Model<ITest>>('insertMany', function(next) {
+  console.log(this.name);
+  next();
+});
+
+schema.pre<Model<ITest>>('insertMany', function(next, doc: ITest) {
+  console.log(this.name, doc);
+  next();
+});
+
+schema.pre<Model<ITest>>('insertMany', function(next, docs: Array<ITest>) {
+  console.log(this.name, docs);
+  next();
+});
+
 const Test = model<ITest>('Test', schema);