@dx-cli-toolbox/sfdx-toolbox-package-utils@0.3.6

Vulnerabilities

3 via 24 paths

Dependencies

452

Source

npm

Find, fix and prevent vulnerabilities in your code.

Severity
  • 3
Status
  • 3
  • 0
  • 0

high severity

Directory Traversal

  • Vulnerable module: adm-zip
  • Introduced through: salesforce-alm@50.17.0

Detailed paths

  • Introduced through: @dx-cli-toolbox/sfdx-toolbox-package-utils@0.3.6 salesforce-alm@50.17.0 adm-zip@0.4.16

Overview

adm-zip is a JavaScript implementation for zip data compression for NodeJS.

Affected versions of this package are vulnerable to Directory Traversal. It could extract files outside the target folder.

Details

A Directory Traversal attack (also known as path traversal) aims to access files and directories that are stored outside the intended folder. By manipulating files with "dot-dot-slash (../)" sequences and its variations, or by using absolute file paths, it may be possible to access arbitrary files and directories stored on file system, including application source code, configuration, and other critical system files.

Directory Traversal vulnerabilities can be generally divided into two types:

  • Information Disclosure: Allows the attacker to gain information about the folder structure or read the contents of sensitive files on the system.

st is a module for serving static files on web pages, and contains a vulnerability of this type. In our example, we will serve files from the public route.

If an attacker requests the following URL from our server, it will in turn leak the sensitive private key of the root user.

curl http://localhost:8080/public/%2e%2e/%2e%2e/%2e%2e/%2e%2e/%2e%2e/root/.ssh/id_rsa

Note %2e is the URL encoded version of . (dot).

  • Writing arbitrary files: Allows the attacker to create or replace existing files. This type of vulnerability is also known as Zip-Slip.

One way to achieve this is by using a malicious zip archive that holds path traversal filenames. When each filename in the zip archive gets concatenated to the target extraction folder, without validation, the final path ends up outside of the target folder. If an executable or a configuration file is overwritten with a file containing malicious code, the problem can turn into an arbitrary code execution issue quite easily.

The following is an example of a zip archive with one benign file and one malicious file. Extracting the malicious file will result in traversing out of the target folder, ending up in /root/.ssh/ overwriting the authorized_keys file:

2018-04-15 22:04:29 .....           19           19  good.txt
2018-04-15 22:04:42 .....           20           20  ../../../../../../root/.ssh/authorized_keys

Remediation

Upgrade adm-zip to version 0.5.2 or higher.

References

high severity

Arbitrary Code Execution

  • Vulnerable module: jsen
  • Introduced through: @salesforce/core@2.20.11, salesforce-alm@50.17.0 and others

Detailed paths

  • Introduced through: @dx-cli-toolbox/sfdx-toolbox-package-utils@0.3.6 @salesforce/core@2.20.11 jsen@0.6.6
  • Introduced through: @dx-cli-toolbox/sfdx-toolbox-package-utils@0.3.6 salesforce-alm@50.17.0 jsen@0.6.6
  • Introduced through: @dx-cli-toolbox/sfdx-toolbox-package-utils@0.3.6 @salesforce/command@3.1.0 @salesforce/core@2.20.11 jsen@0.6.6
  • Introduced through: @dx-cli-toolbox/sfdx-toolbox-package-utils@0.3.6 salesforce-alm@50.17.0 @salesforce/core@2.20.11 jsen@0.6.6
  • Introduced through: @dx-cli-toolbox/sfdx-toolbox-package-utils@0.3.6 salesforce-alm@50.17.0 @salesforce/command@3.1.0 @salesforce/core@2.20.11 jsen@0.6.6
  • Introduced through: @dx-cli-toolbox/sfdx-toolbox-package-utils@0.3.6 salesforce-alm@50.17.0 @salesforce/plugin-analytics@1.12.4 @salesforce/core@2.20.11 jsen@0.6.6
  • Introduced through: @dx-cli-toolbox/sfdx-toolbox-package-utils@0.3.6 salesforce-alm@50.17.0 @salesforce/source-deploy-retrieve@1.1.24 @salesforce/core@2.13.0 jsen@0.6.6
  • Introduced through: @dx-cli-toolbox/sfdx-toolbox-package-utils@0.3.6 salesforce-alm@50.17.0 @salesforce/plugin-analytics@1.12.4 @salesforce/command@3.1.0 @salesforce/core@2.20.11 jsen@0.6.6
  • Introduced through: @dx-cli-toolbox/sfdx-toolbox-package-utils@0.3.6 salesforce-alm@50.17.0 @salesforce/plugin-analytics@1.12.4 @salesforce/telemetry@2.0.5 @salesforce/core@2.20.11 jsen@0.6.6

Overview

jsen is a JSON-Schema validator built for speed

Affected versions of this package are vulnerable to Arbitrary Code Execution. If an attacker can control the schema file, it could run arbitrary JavaScript code on the victim machine. In the module description and README file there is no mention about the risks of untrusted schema files, so I assume that this is applicable.

In particular the required field of the schema is not properly sanitized. The resulting string that is build based on the schema definition is then passed to a Function.apply();, leading to an Arbitrary Code Execution.

PoC

const jsen = require('jsen');

let schema = JSON.parse(`
{
    "type": "object",
    "properties": {
        "username": {
            "type": "string"
        }
    },
    "required": ["\\"+process.mainModule.require(\'child_process\').execSync(\'touch malicious\')+\\""]
}`);

const validate = jsen(schema);
validate({});

Remediation

There is no fixed version for jsen.

References

high severity

Command Injection

  • Vulnerable module: lodash.template
  • Introduced through: @oclif/command@1.8.0, @salesforce/command@3.1.0 and others

Detailed paths

  • Introduced through: @dx-cli-toolbox/sfdx-toolbox-package-utils@0.3.6 @oclif/command@1.8.0 @oclif/plugin-help@3.2.2 lodash.template@4.5.0
  • Introduced through: @dx-cli-toolbox/sfdx-toolbox-package-utils@0.3.6 @salesforce/command@3.1.0 @oclif/plugin-help@2.2.3 lodash.template@4.5.0
  • Introduced through: @dx-cli-toolbox/sfdx-toolbox-package-utils@0.3.6 salesforce-alm@50.17.0 @oclif/plugin-help@2.2.3 lodash.template@4.5.0
  • Introduced through: @dx-cli-toolbox/sfdx-toolbox-package-utils@0.3.6 @salesforce/command@3.1.0 @oclif/command@1.8.0 @oclif/plugin-help@3.2.2 lodash.template@4.5.0
  • Introduced through: @dx-cli-toolbox/sfdx-toolbox-package-utils@0.3.6 salesforce-alm@50.17.0 @salesforce/command@3.1.0 @oclif/plugin-help@2.2.3 lodash.template@4.5.0
  • Introduced through: @dx-cli-toolbox/sfdx-toolbox-package-utils@0.3.6 @salesforce/command@3.1.0 @oclif/plugin-help@2.2.3 @oclif/command@1.8.0 @oclif/plugin-help@3.2.2 lodash.template@4.5.0
  • Introduced through: @dx-cli-toolbox/sfdx-toolbox-package-utils@0.3.6 salesforce-alm@50.17.0 @oclif/plugin-help@2.2.3 @oclif/command@1.8.0 @oclif/plugin-help@3.2.2 lodash.template@4.5.0
  • Introduced through: @dx-cli-toolbox/sfdx-toolbox-package-utils@0.3.6 salesforce-alm@50.17.0 @salesforce/command@3.1.0 @oclif/command@1.8.0 @oclif/plugin-help@3.2.2 lodash.template@4.5.0
  • Introduced through: @dx-cli-toolbox/sfdx-toolbox-package-utils@0.3.6 salesforce-alm@50.17.0 @salesforce/plugin-analytics@1.12.4 @oclif/command@1.8.0 @oclif/plugin-help@3.2.2 lodash.template@4.5.0
  • Introduced through: @dx-cli-toolbox/sfdx-toolbox-package-utils@0.3.6 salesforce-alm@50.17.0 cli-ux@5.5.1 @oclif/command@1.8.0 @oclif/plugin-help@3.2.2 lodash.template@4.5.0
  • Introduced through: @dx-cli-toolbox/sfdx-toolbox-package-utils@0.3.6 salesforce-alm@50.17.0 @salesforce/plugin-analytics@1.12.4 @salesforce/command@3.1.0 @oclif/plugin-help@2.2.3 lodash.template@4.5.0
  • Introduced through: @dx-cli-toolbox/sfdx-toolbox-package-utils@0.3.6 salesforce-alm@50.17.0 @salesforce/command@3.1.0 @oclif/plugin-help@2.2.3 @oclif/command@1.8.0 @oclif/plugin-help@3.2.2 lodash.template@4.5.0
  • Introduced through: @dx-cli-toolbox/sfdx-toolbox-package-utils@0.3.6 salesforce-alm@50.17.0 @salesforce/plugin-analytics@1.12.4 @salesforce/command@3.1.0 @oclif/command@1.8.0 @oclif/plugin-help@3.2.2 lodash.template@4.5.0
  • Introduced through: @dx-cli-toolbox/sfdx-toolbox-package-utils@0.3.6 salesforce-alm@50.17.0 @salesforce/plugin-analytics@1.12.4 @salesforce/command@3.1.0 @oclif/plugin-help@2.2.3 @oclif/command@1.8.0 @oclif/plugin-help@3.2.2 lodash.template@4.5.0

Overview

lodash.template is a The Lodash method _.template exported as a Node.js module.

Affected versions of this package are vulnerable to Command Injection via template.

PoC

var _ = require('lodash');

_.template('', { variable: '){console.log(process.env)}; with(obj' })()

Remediation

There is no fixed version for lodash.template.

References