hyperlab-solutions-sdn-bhd/dialex-sdk-python

Vulnerabilities

7 via 12 paths

Dependencies

9

Source

GitHub

Commit

6a5d39f2

Find, fix and prevent vulnerabilities in your code.

Severity
  • 4
  • 3
Status
  • 7
  • 0
  • 0

high severity

Information Exposure

  • Vulnerable module: requests
  • Introduced through: requests@2.18.4

Detailed paths

  • Introduced through: hyperlab-solutions-sdn-bhd/dialex-sdk-python@hyperlab-solutions-sdn-bhd/dialex-sdk-python#6a5d39f220a369a67bbf22099ee626ce5a90e0ab requests@2.18.4
    Remediation: Upgrade to requests@2.20.0.

Overview

Requests is a Non-GMO HTTP library for Python

Affected versions of this package are vulnerable to Information Exposure. Upon receiving a same-hostname https-to-http redirect, it sends the HTTP Authorization header to an http URI. This makes it easier for remote attackers to discover credentials by sniffing the network.

Remediation

Upgrade request to version 2.20 or higher.

References

high severity

CRLF injection

  • Vulnerable module: urllib3
  • Introduced through: urllib3@1.22 and requests@2.18.4

Detailed paths

  • Introduced through: hyperlab-solutions-sdn-bhd/dialex-sdk-python@hyperlab-solutions-sdn-bhd/dialex-sdk-python#6a5d39f220a369a67bbf22099ee626ce5a90e0ab urllib3@1.22
    Remediation: Upgrade to urllib3@1.24.3.
  • Introduced through: hyperlab-solutions-sdn-bhd/dialex-sdk-python@hyperlab-solutions-sdn-bhd/dialex-sdk-python#6a5d39f220a369a67bbf22099ee626ce5a90e0ab requests@2.18.4 urllib3@1.22

Overview

urllib3 is a HTTP library with thread-safe connection pooling, file post, and more.

Affected versions of this package are vulnerable to CRLF injection. Attacker who has the control of the requesting address parameter, could manipulate an HTTP header and attack an internal service.

PoC

by ragdoll and Alvin Chang

import urllib3

pool_manager = urllib3.PoolManager()

host = "localhost:7777?a=1 HTTP/1.1\r\nX-injected: header\r\nTEST: 123"
url = "http://" + host + ":8080/test/?test=a"

try:
    info = pool_manager.request('GET', url).info()
    print(info)
except Exception:
    pass

# nc -l localhost 7777
GET /?a=1 HTTP/1.1
X-injected: header
TEST: 123:8080/test/?test=a HTTP/1.1
Host: localhost:7777
Accept-Encoding: identity

The nc server will display the HTTP request with a manipulated header content: X-injected:header, indicating a successful injection of the HTTP header.

Remediation

Upgrade urllib3 to version 1.24.3 or higher.

References

high severity

HTTP Header Injection

  • Vulnerable module: urllib3
  • Introduced through: urllib3@1.22 and requests@2.18.4

Detailed paths

  • Introduced through: hyperlab-solutions-sdn-bhd/dialex-sdk-python@hyperlab-solutions-sdn-bhd/dialex-sdk-python#6a5d39f220a369a67bbf22099ee626ce5a90e0ab urllib3@1.22
    Remediation: Upgrade to urllib3@1.25.9.
  • Introduced through: hyperlab-solutions-sdn-bhd/dialex-sdk-python@hyperlab-solutions-sdn-bhd/dialex-sdk-python#6a5d39f220a369a67bbf22099ee626ce5a90e0ab requests@2.18.4 urllib3@1.22

Overview

urllib3 is a HTTP library with thread-safe connection pooling, file post, and more.

Affected versions of this package are vulnerable to HTTP Header Injection. The 'method' parameter is not filtered to prevent the injection from altering the entire request.

For example:

>>> conn = http.client.HTTPConnection("localhost", 80)
>>> conn.request(method="GET / HTTP/1.1\r\nHost: abc\r\nRemainder:", url="/index.html")

This will result in the following request being generated:

GET / HTTP/1.1
Host: abc
Remainder: /index.html HTTP/1.1
Host: localhost
Accept-Encoding: identity

Remediation

Upgrade urllib3 to version 1.25.9 or higher.

References

high severity

Improper Certificate Validation

  • Vulnerable module: urllib3
  • Introduced through: urllib3@1.22 and requests@2.18.4

Detailed paths

  • Introduced through: hyperlab-solutions-sdn-bhd/dialex-sdk-python@hyperlab-solutions-sdn-bhd/dialex-sdk-python#6a5d39f220a369a67bbf22099ee626ce5a90e0ab urllib3@1.22
    Remediation: Upgrade to urllib3@1.24.2.
  • Introduced through: hyperlab-solutions-sdn-bhd/dialex-sdk-python@hyperlab-solutions-sdn-bhd/dialex-sdk-python#6a5d39f220a369a67bbf22099ee626ce5a90e0ab requests@2.18.4 urllib3@1.22

Overview

urllib3 is a HTTP library with thread-safe connection pooling, file post, and more.

Affected versions of this package are vulnerable to Improper Certificate Validation. It mishandles certain cases where the desired set of CA certificates is different from the OS store of CA certificates. This can result in SSL connections succeeding in situations where it should have failed.

Remediation

Upgrade urllib3 to version 1.24.2 or higher.

References

medium severity

Regular Expression Denial of Service (ReDoS)

  • Vulnerable module: py
  • Introduced through: py@1.4.34

Detailed paths

  • Introduced through: hyperlab-solutions-sdn-bhd/dialex-sdk-python@hyperlab-solutions-sdn-bhd/dialex-sdk-python#6a5d39f220a369a67bbf22099ee626ce5a90e0ab py@1.4.34
    Remediation: Upgrade to py@1.10.0.

Overview

py is an a Python development support library.

Affected versions of this package are vulnerable to Regular Expression Denial of Service (ReDoS). The subpattern \d+\s*\S+ is ambiguous which makes the pattern subject to catastrophic backtracing given a string like "1" * 5000.

SVN blame output seems to always have at least one space between the revision number and the user name, so the ambiguity can be fixed by changing the * to +.

Details

Denial of Service (DoS) describes a family of attacks, all aimed at making a system inaccessible to its original and legitimate users. There are many types of DoS attacks, ranging from trying to clog the network pipes to the system by generating a large volume of traffic from many machines (a Distributed Denial of Service - DDoS - attack) to sending crafted requests that cause a system to crash or take a disproportional amount of time to process.

The Regular expression Denial of Service (ReDoS) is a type of Denial of Service attack. Regular expressions are incredibly powerful, but they aren't very intuitive and can ultimately end up making it easy for attackers to take your site down.

Let’s take the following regular expression as an example:

regex = /A(B|C+)+D/

This regular expression accomplishes the following:

  • A The string must start with the letter 'A'
  • (B|C+)+ The string must then follow the letter A with either the letter 'B' or some number of occurrences of the letter 'C' (the + matches one or more times). The + at the end of this section states that we can look for one or more matches of this section.
  • D Finally, we ensure this section of the string ends with a 'D'

The expression would match inputs such as ABBD, ABCCCCD, ABCBCCCD and ACCCCCD

It most cases, it doesn't take very long for a regex engine to find a match:

$ time node -e '/A(B|C+)+D/.test("ACCCCCCCCCCCCCCCCCCCCCCCCCCCCD")'
0.04s user 0.01s system 95% cpu 0.052 total

$ time node -e '/A(B|C+)+D/.test("ACCCCCCCCCCCCCCCCCCCCCCCCCCCCX")'
1.79s user 0.02s system 99% cpu 1.812 total

The entire process of testing it against a 30 characters long string takes around ~52ms. But when given an invalid string, it takes nearly two seconds to complete the test, over ten times as long as it took to test a valid string. The dramatic difference is due to the way regular expressions get evaluated.

Most Regex engines will work very similarly (with minor differences). The engine will match the first possible way to accept the current character and proceed to the next one. If it then fails to match the next one, it will backtrack and see if there was another way to digest the previous character. If it goes too far down the rabbit hole only to find out the string doesn’t match in the end, and if many characters have multiple valid regex paths, the number of backtracking steps can become very large, resulting in what is known as catastrophic backtracking.

Let's look at how our expression runs into this problem, using a shorter string: "ACCCX". While it seems fairly straightforward, there are still four different ways that the engine could match those three C's:

  1. CCC
  2. CC+C
  3. C+CC
  4. C+C+C.

The engine has to try each of those combinations to see if any of them potentially match against the expression. When you combine that with the other steps the engine must take, we can use RegEx 101 debugger to see the engine has to take a total of 38 steps before it can determine the string doesn't match.

From there, the number of steps the engine must use to validate a string just continues to grow.

String Number of C's Number of steps
ACCCX 3 38
ACCCCX 4 71
ACCCCCX 5 136
ACCCCCCCCCCCCCCX 14 65,553

By the time the string includes 14 C's, the engine has to take over 65,000 steps just to see if the string is valid. These extreme situations can cause them to work very slowly (exponentially related to input size, as shown above), allowing an attacker to exploit this and can cause the service to excessively consume CPU, resulting in a Denial of Service.

Remediation

Upgrade py to version 1.10.0 or higher.

References

medium severity

Authentication Bypass

  • Vulnerable module: urllib3
  • Introduced through: urllib3@1.22 and requests@2.18.4

Detailed paths

  • Introduced through: hyperlab-solutions-sdn-bhd/dialex-sdk-python@hyperlab-solutions-sdn-bhd/dialex-sdk-python#6a5d39f220a369a67bbf22099ee626ce5a90e0ab urllib3@1.22
    Remediation: Upgrade to urllib3@1.23.
  • Introduced through: hyperlab-solutions-sdn-bhd/dialex-sdk-python@hyperlab-solutions-sdn-bhd/dialex-sdk-python#6a5d39f220a369a67bbf22099ee626ce5a90e0ab requests@2.18.4 urllib3@1.22

Overview

urllib3 is a HTTP library with thread-safe connection pooling, file post, and more.

Affected versions of this package are vulnerable to Authentication Bypass. It did remove the Authorization HTTP header when following a cross-origin redirect. This can allow for credentials in the Authorization header to be exposed to unintended hosts or transmitted in cleartext.

Remediation

Upgrade urllib3 to version 1.23 or higher.

References

medium severity

Regular Expression Denial of Service (ReDoS)

  • Vulnerable module: urllib3
  • Introduced through: urllib3@1.22 and requests@2.18.4

Detailed paths

  • Introduced through: hyperlab-solutions-sdn-bhd/dialex-sdk-python@hyperlab-solutions-sdn-bhd/dialex-sdk-python#6a5d39f220a369a67bbf22099ee626ce5a90e0ab urllib3@1.22
    Remediation: Upgrade to urllib3@1.26.5.
  • Introduced through: hyperlab-solutions-sdn-bhd/dialex-sdk-python@hyperlab-solutions-sdn-bhd/dialex-sdk-python#6a5d39f220a369a67bbf22099ee626ce5a90e0ab requests@2.18.4 urllib3@1.22

Overview

urllib3 is a HTTP library with thread-safe connection pooling, file post, and more.

Affected versions of this package are vulnerable to Regular Expression Denial of Service (ReDoS) via the SUBAUTHORITY_PAT regex pattern in src/urllib3/util/url.py.

If a URL is passed as a parameter or redirected to via an HTTP redirect and it contains many @ characters in the authority component, the authority regular expression exhibits catastrophic backtracking, causing a denial of service.

Details

Denial of Service (DoS) describes a family of attacks, all aimed at making a system inaccessible to its original and legitimate users. There are many types of DoS attacks, ranging from trying to clog the network pipes to the system by generating a large volume of traffic from many machines (a Distributed Denial of Service - DDoS - attack) to sending crafted requests that cause a system to crash or take a disproportional amount of time to process.

The Regular expression Denial of Service (ReDoS) is a type of Denial of Service attack. Regular expressions are incredibly powerful, but they aren't very intuitive and can ultimately end up making it easy for attackers to take your site down.

Let’s take the following regular expression as an example:

regex = /A(B|C+)+D/

This regular expression accomplishes the following:

  • A The string must start with the letter 'A'
  • (B|C+)+ The string must then follow the letter A with either the letter 'B' or some number of occurrences of the letter 'C' (the + matches one or more times). The + at the end of this section states that we can look for one or more matches of this section.
  • D Finally, we ensure this section of the string ends with a 'D'

The expression would match inputs such as ABBD, ABCCCCD, ABCBCCCD and ACCCCCD

It most cases, it doesn't take very long for a regex engine to find a match:

$ time node -e '/A(B|C+)+D/.test("ACCCCCCCCCCCCCCCCCCCCCCCCCCCCD")'
0.04s user 0.01s system 95% cpu 0.052 total

$ time node -e '/A(B|C+)+D/.test("ACCCCCCCCCCCCCCCCCCCCCCCCCCCCX")'
1.79s user 0.02s system 99% cpu 1.812 total

The entire process of testing it against a 30 characters long string takes around ~52ms. But when given an invalid string, it takes nearly two seconds to complete the test, over ten times as long as it took to test a valid string. The dramatic difference is due to the way regular expressions get evaluated.

Most Regex engines will work very similarly (with minor differences). The engine will match the first possible way to accept the current character and proceed to the next one. If it then fails to match the next one, it will backtrack and see if there was another way to digest the previous character. If it goes too far down the rabbit hole only to find out the string doesn’t match in the end, and if many characters have multiple valid regex paths, the number of backtracking steps can become very large, resulting in what is known as catastrophic backtracking.

Let's look at how our expression runs into this problem, using a shorter string: "ACCCX". While it seems fairly straightforward, there are still four different ways that the engine could match those three C's:

  1. CCC
  2. CC+C
  3. C+CC
  4. C+C+C.

The engine has to try each of those combinations to see if any of them potentially match against the expression. When you combine that with the other steps the engine must take, we can use RegEx 101 debugger to see the engine has to take a total of 38 steps before it can determine the string doesn't match.

From there, the number of steps the engine must use to validate a string just continues to grow.

String Number of C's Number of steps
ACCCX 3 38
ACCCCX 4 71
ACCCCCX 5 136
ACCCCCCCCCCCCCCX 14 65,553

By the time the string includes 14 C's, the engine has to take over 65,000 steps just to see if the string is valid. These extreme situations can cause them to work very slowly (exponentially related to input size, as shown above), allowing an attacker to exploit this and can cause the service to excessively consume CPU, resulting in a Denial of Service.

Remediation

Upgrade urllib3 to version 1.26.5 or higher.

References