Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: websockets/ws
base: 38c6c734daf8e15d5cd902ed3e47b8651fd1032c
Choose a base ref
...
head repository: websockets/ws
compare: 8ecd890800dfbe210298438ab9bb8dbe328f3e0b
Choose a head ref
  • 19 commits
  • 13 files changed
  • 1 contributor

Commits on Jul 3, 2021

  1. [fix] Abort the handshake if an unexpected extension is received

    Abort the handshake if the client receives a `Sec-WebSocket-Extensions`
    header but no extension was requested. Also abort the handshake if the
    server indicates an extension not requested by the client.
    lpinca committed Jul 3, 2021
    Copy the full SHA
    aca94c8 View commit details
    Browse the repository at this point in the history

Commits on Jul 4, 2021

  1. [dist] 7.5.2

    lpinca committed Jul 4, 2021
    Copy the full SHA
    0ad1f9d View commit details
    Browse the repository at this point in the history

Commits on Jul 7, 2021

  1. Copy the full SHA
    ecb9d9e View commit details
    Browse the repository at this point in the history

Commits on Jul 8, 2021

  1. [fix] Make the {noS,s}erver, and port options mutually exclusive

    Remove ambiguity and prevent `WebSocketServer.prototype.address()` from
    throwing an error if the `noServer` option is used along with the
    `port` and/or `server` options.
    lpinca committed Jul 8, 2021
    Copy the full SHA
    66e58d2 View commit details
    Browse the repository at this point in the history
  2. [minor] Fix typo

    lpinca committed Jul 8, 2021
    Copy the full SHA
    ea63b29 View commit details
    Browse the repository at this point in the history

Commits on Jul 9, 2021

  1. [fix] Emit the 'close' event after the server is closed

    Ensure that `WebSocketServer.prototype.close()` does not emit a
    `'close'` event prematurely if called while the internal HTTP/S server
    is closing.
    lpinca committed Jul 9, 2021
    Copy the full SHA
    5a58730 View commit details
    Browse the repository at this point in the history
  2. [fix] Abort the handshake if the server is closing or closed

    Prevent WebSocket connections from being established after
    `WebSocketServer.prototype.close()` is called.
    lpinca committed Jul 9, 2021
    Copy the full SHA
    772236a View commit details
    Browse the repository at this point in the history

Commits on Jul 10, 2021

  1. [dist] 7.5.3

    lpinca committed Jul 10, 2021
    Copy the full SHA
    4c1849a View commit details
    Browse the repository at this point in the history

Commits on Aug 28, 2021

  1. [fix] Do not rely on undocumented behavior

    Use the chunk returned by `socket.read()` to handle the buffered data
    instead of relying on a `'data'` event emitted after the `'close'`
    event.
    
    Refs: nodejs/node#39639
    lpinca committed Aug 28, 2021
    Copy the full SHA
    76087fb View commit details
    Browse the repository at this point in the history
  2. [fix] Resume the socket in the next tick

    Ensure that `socket.resume()` is called after `socket.pause()`.
    
    Fixes #1940
    lpinca committed Aug 28, 2021
    Copy the full SHA
    2799793 View commit details
    Browse the repository at this point in the history
  3. [dist] 7.5.4

    lpinca committed Aug 28, 2021
    Copy the full SHA
    075752d View commit details
    Browse the repository at this point in the history

Commits on Sep 8, 2021

  1. [minor] Skip unnecessary operations if the socket is already closed

    There is no need to remove the already removed `socketOnData` listener,
    resume the socket, and call `websocket.close()` if the socket is already
    closed.
    lpinca committed Sep 8, 2021
    Copy the full SHA
    0e274ac View commit details
    Browse the repository at this point in the history
  2. Copy the full SHA
    e519810 View commit details
    Browse the repository at this point in the history
  3. Copy the full SHA
    aa21e70 View commit details
    Browse the repository at this point in the history
  4. [doc] Change label text to CI

    lpinca committed Sep 8, 2021
    Copy the full SHA
    ab5fcd6 View commit details
    Browse the repository at this point in the history
  5. [dist] 7.5.5

    lpinca committed Sep 8, 2021
    Copy the full SHA
    2d968a6 View commit details
    Browse the repository at this point in the history

Commits on Nov 23, 2021

  1. [fix] Do not throw if the redirect URL is invalid

    If the redirect URL is invalid, then emit the error instead of throwing
    it, otherwise there is no way to handle it.
    lpinca committed Nov 23, 2021
    Copy the full SHA
    73dec34 View commit details
    Browse the repository at this point in the history
  2. [fix] Resume the socket in the CLOSING state

    When the value of the `readyState` attribute is `CLOSING`, the internal
    socket might still be open. Resume it to read any remaining data and to
    allow the connection to be closed cleanly.
    lpinca committed Nov 23, 2021
    Copy the full SHA
    22a26af View commit details
    Browse the repository at this point in the history
  3. [dist] 7.5.6

    lpinca committed Nov 23, 2021
    Copy the full SHA
    8ecd890 View commit details
    Browse the repository at this point in the history