Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: added the watch command #2357

Merged
merged 7 commits into from Jan 18, 2021
Merged

feat: added the watch command #2357

merged 7 commits into from Jan 18, 2021

Conversation

alexander-akait
Copy link
Member

@alexander-akait alexander-akait commented Jan 15, 2021

What kind of change does this PR introduce?

feature

Did you add tests for your changes?

Yes

If relevant, did you update the documentation?

Yes

Summary

Many popular tools have the watch command, let's do the same and we will have good built-in command:

  • webpack configtest
  • webpack build
  • webpack watch
  • webpack serve
  • webpack info
  • webpack help
  • webpack version
  • webpack init (we need focus on it)

Does this PR introduce a breaking change?

No

Other information

After this I will focus on webpack index.js, after refactor we can return this again, but with some limitations, I will describe them in the PR

@codecov
Copy link

codecov bot commented Jan 15, 2021

Codecov Report

Merging #2357 (95e785b) into master (487691a) will increase coverage by 0.73%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2357      +/-   ##
==========================================
+ Coverage   69.47%   70.21%   +0.73%     
==========================================
  Files          47       47              
  Lines        2110     2122      +12     
  Branches      541      547       +6     
==========================================
+ Hits         1466     1490      +24     
+ Misses        644      632      -12     
Impacted Files Coverage Δ
packages/configtest/src/index.ts 96.55% <100.00%> (-0.12%) ⬇️
packages/webpack-cli/lib/webpack-cli.js 91.02% <100.00%> (+0.16%) ⬆️
packages/webpack-cli/lib/utils/logger.js 100.00% <0.00%> (+11.11%) ⬆️
packages/serve/src/index.ts 83.92% <0.00%> (+19.64%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 487691a...95e785b. Read the comment docs.

@@ -1373,6 +1396,7 @@ class WebpackCLI {
}

if (options.json) {
const { stringifyStream: createJsonStringifyStream } = require('@discoveryjs/json-ext');
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reduce time to initial run

Co-authored-by: James George <jamesgeorge998001@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants