Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: pass all argv to configurations when serve command used #2345

Merged
merged 4 commits into from Jan 13, 2021

Conversation

alexander-akait
Copy link
Member

What kind of change does this PR introduce?

bugfix

Did you add tests for your changes?

Yes

If relevant, did you update the documentation?

No need

Summary

fixes #2962 (I think it was fixed, but no, so let's fix)

Does this PR introduce a breaking change?

No

Other information

No

@alexander-akait
Copy link
Member Author

Smoketests again broken, apparently I need to rewrite them again 😞

@codecov
Copy link

codecov bot commented Jan 12, 2021

Codecov Report

Merging #2345 (184d5f4) into master (debb857) will increase coverage by 0.01%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2345      +/-   ##
==========================================
+ Coverage   68.17%   68.19%   +0.01%     
==========================================
  Files          50       50              
  Lines        2052     2053       +1     
  Branches      506      509       +3     
==========================================
+ Hits         1399     1400       +1     
  Misses        653      653              
Impacted Files Coverage Δ
packages/serve/src/index.ts 64.28% <100.00%> (ø)
packages/webpack-cli/lib/webpack-cli.js 89.86% <100.00%> (+0.01%) ⬆️
packages/generators/src/loader-generator.ts 91.66% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update debb857...184d5f4. Read the comment docs.

@alexander-akait alexander-akait merged commit 5070b9b into master Jan 13, 2021
@alexander-akait alexander-akait deleted the fix-argv-for-serve branch January 13, 2021 10:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants