Skip to content

Commit

Permalink
chore: remove pify in favour of util.promisify (#323)
Browse files Browse the repository at this point in the history
  • Loading branch information
Ryan Clark committed Mar 16, 2020
1 parent fed50ba commit 6fc1392
Show file tree
Hide file tree
Showing 5 changed files with 11 additions and 10 deletions.
3 changes: 2 additions & 1 deletion package-lock.json

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

1 change: 0 additions & 1 deletion package.json
Expand Up @@ -45,7 +45,6 @@
"dependencies": {
"clone": "^2.1.1",
"loader-utils": "^1.4.0",
"pify": "^4.0.1",
"schema-utils": "^2.6.5"
},
"devDependencies": {
Expand Down
7 changes: 4 additions & 3 deletions src/createWebpackLessPlugin.js
@@ -1,5 +1,6 @@
import { promisify } from 'util';

import less from 'less';
import pify from 'pify';

import { urlToRequest } from 'loader-utils';

Expand Down Expand Up @@ -32,8 +33,8 @@ const isModuleName = /^~[^/\\]+$/;
function createWebpackLessPlugin(loaderContext) {
const { fs } = loaderContext;

const loadModule = pify(loaderContext.loadModule.bind(loaderContext));
const readFile = pify(fs.readFile.bind(fs));
const loadModule = promisify(loaderContext.loadModule.bind(loaderContext));
const readFile = promisify(fs.readFile.bind(fs));

const resolve = loaderContext.getResolve({
mainFields: ['less', 'style', 'main', '...'],
Expand Down
5 changes: 3 additions & 2 deletions src/index.js
@@ -1,5 +1,6 @@
import { promisify } from 'util';

import less from 'less';
import pify from 'pify';

import { getOptions } from 'loader-utils';
import validateOptions from 'schema-utils';
Expand All @@ -8,7 +9,7 @@ import schema from './options.json';
import processResult from './processResult';
import getLessOptions from './getLessOptions';

const render = pify(less.render.bind(less));
const render = promisify(less.render.bind(less));

function lessLoader(source) {
const options = getOptions(this) || {};
Expand Down
5 changes: 2 additions & 3 deletions test/helpers/readFixture.js
@@ -1,9 +1,8 @@
const path = require('path');
const fs = require('fs');
const util = require('util');

const pify = require('pify');

const readFile = pify(fs.readFile);
const readFile = util.promisify(fs.readFile);
const testFolder = path.resolve(__dirname, '..');

function readCssFixture(testId) {
Expand Down

0 comments on commit 6fc1392

Please sign in to comment.