fix: handle only valid srcset tags (#253)

webpack-contrib · Mar 12, 2020 · fcba4ec · fcba4ec
1 parent 9e5ce56
commit fcba4ec
Show file tree

Hide file tree

Showing 2 changed files with 10 additions and 9 deletions.
diff --git a/README.md b/README.md
@@ -53,18 +53,18 @@ You may need to specify loaders for images in your configuration (recommended `f
 
 ## Options
 
-|               Name                |        Type         |                                                               Default                                                               | Description                              |
-| :-------------------------------: | :-----------------: | :---------------------------------------------------------------------------------------------------------------------------------: | :--------------------------------------- |
-|  **[`attributes`](#attributes)**  | `{Boolean\/Array}`  | `[':srcset', 'img:src', 'audio:src', 'video:src', 'track:src', 'embed:src', 'source:src','input:src', 'object:data', 'script:src']` | Enables/Disables attributes handling     |
-|        **[`root`](#root)**        |     `{String}`      |                                                             `undefiend`                                                             | Allow to handle root-relative attributes |
-| **[`interpolate`](#interpolate)** |     `{Boolean}`     |                                                               `false`                                                               | Allow to use expressions in HTML syntax  |
-|    **[`minimize`](#minimize)**    | `{Boolean\|Object}` |                                            `true` in production mode, otherwise `false`                                             | Tell `html-loader` to minimize HTML      |
-|    **[`esModule`](#esmodule)**    |     `{Boolean}`     |                                                               `false`                                                               | Use ES modules syntax                    |
+|               Name                |        Type         |                                                                         Default                                                                         | Description                              |
+| :-------------------------------: | :-----------------: | :-----------------------------------------------------------------------------------------------------------------------------------------------------: | :--------------------------------------- |
+|  **[`attributes`](#attributes)**  | `{Boolean\/Array}`  | `['source:srcset', 'img:src', 'img:srcset', 'audio:src', 'video:src', 'track:src', 'embed:src', 'source:src','input:src', 'object:data', 'script:src']` | Enables/Disables attributes handling     |
+|        **[`root`](#root)**        |     `{String}`      |                                                                       `undefiend`                                                                       | Allow to handle root-relative attributes |
+| **[`interpolate`](#interpolate)** |     `{Boolean}`     |                                                                         `false`                                                                         | Allow to use expressions in HTML syntax  |
+|    **[`minimize`](#minimize)**    | `{Boolean\|Object}` |                                                      `true` in production mode, otherwise `false`                                                       | Tell `html-loader` to minimize HTML      |
+|    **[`esModule`](#esmodule)**    |     `{Boolean}`     |                                                                         `false`                                                                         | Use ES modules syntax                    |
 
 ### `attributes`
 
 Type: `Boolean|Array`
-Default: `[':srcset', 'img:src', 'audio:src', 'video:src', 'track:src', 'embed:src', 'source:src', 'input:src', 'object:data', 'script:src']`
+Default: `['source:srcset', 'img:src', 'img:srcset', 'audio:src', 'video:src', 'track:src', 'embed:src', 'source:src','input:src', 'object:data', 'script:src']`
 
 #### `Boolean`
 

diff --git a/src/plugins/source-plugin.js b/src/plugins/source-plugin.js
@@ -378,8 +378,9 @@ export default (options) =>
     const tagsAndAttributes =
       typeof options.attributes === 'undefined' || options.attributes === true
         ? [
-            ':srcset',
+            'source:srcset',
             'img:src',
+            'img:srcset',
             'audio:src',
             'video:src',
             'track:src',