fix: respect #hash in sources

webpack-contrib · Mar 11, 2020 · 079d623 · 079d623
1 parent a17df49
commit 079d623
Show file tree

Hide file tree

Showing 7 changed files with 214 additions and 48 deletions.
diff --git a/src/plugins/source-plugin.js b/src/plugins/source-plugin.js
@@ -516,13 +516,19 @@ export default (options) =>
     let offset = 0;
 
     for (const source of sources) {
-      const { value, startIndex, unquoted } = source;
-      const uri = parse(value);
+      const { startIndex, unquoted } = source;
+      let { value } = source;
+      const URLObject = parse(value);
 
-      if (typeof uri.hash !== 'undefined') {
-        uri.hash = null;
+      if (typeof URLObject.hash !== 'undefined') {
+        const { hash } = URLObject;
 
-        source.value = uri.format();
+        URLObject.hash = null;
+        source.value = URLObject.format();
+
+        if (hash) {
+          value = value.slice(0, value.length - hash.length);
+        }
       }
 
       const importKey = urlToRequest(

diff --git a/test/__snapshots__/attributes-option.test.js.snap b/test/__snapshots__/attributes-option.test.js.snap
diff --git a/test/__snapshots__/esModule-option.test.js.snap b/test/__snapshots__/esModule-option.test.js.snap
diff --git a/test/__snapshots__/loader.test.js.snap b/test/__snapshots__/loader.test.js.snap
diff --git a/test/__snapshots__/minimize-option.test.js.snap b/test/__snapshots__/minimize-option.test.js.snap
diff --git a/test/__snapshots__/root-option.test.js.snap b/test/__snapshots__/root-option.test.js.snap
diff --git a/test/fixtures/simple.html b/test/fixtures/simple.html
@@ -224,3 +224,11 @@ <h2>An Ordered HTML List</h2>
 <img src      =      ~aliasImageWithSpace      />
 <img src      =      "~aliasImageWithSpace"      />
 <img src      =      '~aliasImageWithSpace'      />
+
+<img src="#hash" />
+<img src="javascript:void(0)" />
+<img src='image.png#hash' />
+<img src=image.png#hash />
+<img src=image.png# />
+<img srcset="image.png#hash" />
+<img srcset="image.png#foo 480w, image.png#bar 800w" sizes="(max-width: 600px) 480px, 800px" src="image.png#baz" alt="Elva dressed as a fairy">