Fix: add missing function type "receive" #5165
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This PR adds missing type "receive"
example in solidity:
```solidity
receive() external payable {
// any code
}
```
jdevcs
reviewed
Jun 28, 2022
There was a problem hiding this comment.
@itxtoledo Thanks for your contribution. changelog.md update is also required.
Pull Request Test Coverage Report for Build 2867694442
💛 - Coveralls |
luu-alex
approved these changes
Jul 10, 2022
nikoulai
approved these changes
Jul 11, 2022
avkos
approved these changes
Jul 11, 2022
jdevcs
changed the base branch from
1.x
to
junaid/5165missingfunctiontypereceivee2e
31 tasks
jdevcs
added a commit
that referenced
this pull request
Sep 6, 2022
* Fix: add missing function type "receive"
This PR adds missing type "receive"
example in solidity:
```solidity
receive() external payable {
// any code
}
```
* Update Changgelog
* Update CHANGELOG.md
* Update CHANGELOG.md
Co-authored-by: Oleksii Kosynskyi <oleksii.kosynskyi@gmail.com>
Co-authored-by: Junaid <86780488+jdevcs@users.noreply.github.com>
Co-authored-by: Alex <alex.luu@mail.utoronto.ca>
Co-authored-by: Alex <luu.alex98@gmail.com>
Co-authored-by: Gustavo <gustavo@obex.pw>
Co-authored-by: Oleksii Kosynskyi <oleksii.kosynskyi@gmail.com>
Co-authored-by: Alex <alex.luu@mail.utoronto.ca>
Co-authored-by: Alex <luu.alex98@gmail.com>
|
Merged into 1.x via #5165 |
Merged
This was referenced Oct 23, 2022
This was referenced Jan 2, 2023
This was referenced Feb 15, 2023
This was referenced Feb 15, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds missing type "receive"
example in solidity:
Description
Please include a summary of the changes and be sure to follow our Contribution Guidelines.
Type of change
Checklist:
npm run dtslintwith success and extended the tests and types if necessary.npm run test:covand my test cases cover all the lines and branches of the added code.npm run buildwith success.dist/web3.min.jsin a browser.CHANGELOG.mdfile in the root folder.