Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Exposing web3.eth.Contract.setProvider() as per public documentation #5001

Merged
merged 3 commits into from
May 4, 2022
Merged

Exposing web3.eth.Contract.setProvider() as per public documentation #5001

merged 3 commits into from
May 4, 2022

Conversation

jdevcs
Copy link
Contributor

@jdevcs jdevcs commented May 4, 2022

This PR is for e2e win tests of (#4822) in github CI actions and changelog update.

Description

Please include a summary of the changes and be sure to follow our Contribution Guidelines.

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist:

  • I have selected the correct base branch.
  • I have performed a self-review of my own code.
  • I have commented my code, particularly in hard-to-understand areas.
  • I have made corresponding changes to the documentation.
  • My changes generate no new warnings.
  • Any dependent changes have been merged and published in downstream modules.
  • I ran npm run dtslint with success and extended the tests and types if necessary.
  • I ran npm run test:cov and my test cases cover all the lines and branches of the added code.
  • I ran npm run build with success.
  • I have tested the built dist/web3.min.js in a browser.
  • I have tested my code on the live network.
  • I have checked the Deploy Preview and it looks correct.
  • I have updated the CHANGELOG.md file in the root folder.

@sdesalas
Exposing web3.eth.Contract.setProvider() as per public documentation (#…
6b27967 
…4822)

* Exposing web3.eth.Contract.setProvider() as per public documentation

* Additional TS defs for web3.eth.Contract.setProvider() as suggested (#4770)

* Additional TS defs for web3.eth.Contract.setProvider()
@jdevcs jdevcs added the 1.x 1.0 related issues label May 4, 2022
@jdevcs jdevcs self-assigned this May 4, 2022
@render
Copy link

render bot commented May 4, 2022

Your Render PR Server URL is https://web3-js-pr-5001.onrender.com.

Follow its progress at https://dashboard.render.com/static/srv-c9p7esv5f99bvqe4pj9g.

@coveralls
Copy link

coveralls commented May 4, 2022 •
edited

Pull Request Test Coverage Report for Build 2270054447

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 74.495%
Totals Coverage Status
Change from base Build 2269832939: 0.0%
Covered Lines: 3242
Relevant Lines: 4107
💛 - Coveralls

@jdevcs
Copy link
Contributor Author

jdevcs commented May 4, 2022

All changes in code of this PR already have approvals in #4822 so merging.

@jdevcs jdevcs merged commit 1f7ae5d into 1.x May 4, 2022
@jdevcs jdevcs deleted the junaid/4822web3EthContractSetProviderexposingtests branch May 4, 2022 13:59
@jdevcs jdevcs mentioned this pull request May 17, 2022
Merged
@Manny27nyc Manny27nyc mentioned this pull request Aug 10, 2022
Open
@PinkDiamond1 PinkDiamond1 mentioned this pull request Aug 10, 2022
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@jdevcs jdevcs

Labels
1.x 1.0 related issues
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@jdevcs @coveralls @sdesalas