Update index.d.ts #4955
Merged
Update index.d.ts #4955
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
this callback returns an array of event data
avkos
approved these changes
Apr 25, 2022
avkos
approved these changes
Apr 26, 2022
nazarhussain
approved these changes
Apr 26, 2022
nazarhussain
requested changes
Apr 26, 2022
There was a problem hiding this comment.
@bigbizze Please add details to the CHANGELOG.md rest seems good.
avkos
approved these changes
Apr 26, 2022
Pull Request Test Coverage Report for Build 2338930161
💛 - Coveralls |
|
@bigbizze Did you get chance to look into this PR. Please add the CHANGELOG.md entry so we can get this PR ready to merge. |
nazarhussain
approved these changes
May 17, 2022
|
This PR has been automatically marked as stale beacause it has not had recent activity. It will be closed in 7 days if no further activity occurs. Thank you for your contributions. If you believe this was a mistake, please comment. |
avkos
added a commit
that referenced
this pull request
Sep 20, 2022
* Update CHANGELOG.md * Update index.d.ts (#4955) this callback returns an array of event data Co-authored-by: Oleksii Kosynskyi <oleksii.kosynskyi@gmail.com> Co-authored-by: Nazar Hussain <nazarhussain@gmail.com> Co-authored-by: Nikos Iliakis <nikoulai@users.noreply.github.com> * Update CHANGELOG.md * Update CHANGELOG.md Co-authored-by: Junaid <86780488+jdevcs@users.noreply.github.com> * Apply suggestions from code review Co-authored-by: Muhammad Altabba <24407834+Muhammad-Altabba@users.noreply.github.com> * fix CHANGELOG Co-authored-by: bigbizze <42508203+bigbizze@users.noreply.github.com> Co-authored-by: Oleksii Kosynskyi <oleksii.kosynskyi@gmail.com> Co-authored-by: Nikos Iliakis <nikoulai@users.noreply.github.com> Co-authored-by: Junaid <86780488+jdevcs@users.noreply.github.com> Co-authored-by: Muhammad Altabba <24407834+Muhammad-Altabba@users.noreply.github.com> Co-authored-by: Alex <alex.luu@mail.utoronto.ca>
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
the changed callback type returns an array of event data rather than an object of one event's data: https://www.quicknode.com/docs/ethereum/eth_getLogs