Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove polyfill packages to support webpack 5 #5053

Closed
luu-alex opened this issue May 19, 2022 · 4 comments
Closed

remove polyfill packages to support webpack 5 #5053

luu-alex opened this issue May 19, 2022 · 4 comments
Labels
1.x 1.0 related issues Investigate

Comments

@luu-alex
Copy link
Contributor

connected to #5031 in order to support create-react-app and angular5 out of the box with web3js we need to get rid of these dependancies from our library:
crypto-browserify,
stream-browserify,
assert,
stream-http,
https-browserify,
os-browserify,
url

@luu-alex luu-alex added 1.x 1.0 related issues Investigate labels May 19, 2022
@marko911
Copy link

+1 on this. This causes a lot of problems for bundling and tons of workarounds need to be injected to get things working.

@github-actions
Copy link

This issue has been automatically marked as stale because it has not had recent activity. It will be closed in 7 days if no further activity occurs. Thank you for your contributions. If you believe this was a mistake, please comment.

@github-actions github-actions bot added the Stale Has not received enough activity label Jul 20, 2022
@luu-alex luu-alex removed the Stale Has not received enough activity label Jul 21, 2022
@jdevcs jdevcs mentioned this issue Sep 8, 2022
@jdevcs
Copy link
Contributor

jdevcs commented Sep 8, 2022

@luu-alex can we close this issue?

@luu-alex luu-alex closed this as completed Sep 8, 2022
@luu-alex
Copy link
Contributor Author

luu-alex commented Sep 8, 2022

@jdevcs closed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
1.x 1.0 related issues Investigate
Projects
None yet
Development

No branches or pull requests

3 participants