feat(MdTable): reactive selection #1358
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
an easy way to handle multiple selection fix #1348
…of id comparing both `MdTable` and `MdTableRow` emit `md-selected` event to avoid breaking change
…le selecting mode
…be tick from `md-selected-value
too many duplicated events on a selection. It should be emit from `MdTable` BREAKING CHANGE: no more `md-selected` event from `MdTableRow`
|
Reactivity is a bit weird https://codesandbox.io/s/lp7117wylq it only works after next tick... should be built in |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
BREAKING CHANGE: no more
md-selectedevent fromMdTableRowbecause of too many duplicated events on a selection. It should be emitted only fromMdTableboth insingleandmultipleselecting mode. It was emitted fromMdTableRowinsingleand fromMdTableinmultiplebefore.Feature
new props
:md-selected-value.syncfor reactive selection.Notice that disabled row could be selected from
:md-selected-value.fix #1292
Refactor & fix
MdTable.selectedItems,MdTable.selectablechange type to array for easier selection controlling.Selection is determined by instance comparing now.
It was determined by comparing ids in single selection mode and comparing indexes in multiple selection mode before. The indexes way is not sorting the checkbox while sorting because the item is change and index is not. And it could also make duplicated items in
selectedItemsorselectable.fix #1348