Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Update testing.md #39195

Merged
merged 2 commits into from Jul 31, 2022
Merged

fix: Update testing.md #39195

merged 2 commits into from Jul 31, 2022

Conversation

santidalmasso
Copy link
Contributor

@santidalmasso santidalmasso commented Jul 31, 2022 •
edited by ijjk

Update e2e/example.spec.ts (/docs/testing page) to fix the failed test. Fixes: #39194

Bug

  • Related issues linked using fixes #number
  • Integration tests added
  • Errors have helpful link attached, see contributing.md

Feature

  • Implements an existing feature request or RFC. Make sure the feature request has been accepted for implementation before opening a PR.
  • Related issues linked using fixes #number
  • Integration tests added
  • Documentation added
  • Telemetry added. In case of a feature if it's used or not.
  • Errors have helpful link attached, see contributing.md

Documentation / Examples

  • Make sure the linting passes by running pnpm lint
  • The examples guidelines are followed from our contributing doc

@santidalmasso
Update testing.md (vercel#39194)
077d9c9 
Change `e2e/example.spec.ts` to fix the failed test.
@santidalmasso santidalmasso changed the title fix: Update testing.md (#39194) fix: Update testing.md Jul 31, 2022
ijjk
ijjk approved these changes Jul 31, 2022
View reviewed changes
Copy link
Member

@ijjk ijjk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch, thanks!

@kodiakhq kodiakhq bot merged commit de6fc1c into vercel:canary Jul 31, 2022
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 31, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@ijjk ijjk ijjk approved these changes

@timneutkens timneutkens Awaiting requested review from timneutkens

@shuding shuding Awaiting requested review from shuding

@styfle styfle Awaiting requested review from styfle

@huozhi huozhi Awaiting requested review from huozhi

@padmaia padmaia Awaiting requested review from padmaia

@leerob leerob Awaiting requested review from leerob

@balazsorban44 balazsorban44 Awaiting requested review from balazsorban44

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Docs: Playwright e2e sample test fails
2 participants
@santidalmasso @ijjk