Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: missing semicolon on Dockerfile #39142

Merged
merged 1 commit into from
Jul 28, 2022
Merged

fix: missing semicolon on Dockerfile #39142

merged 1 commit into from
Jul 28, 2022

Conversation

qutek
Copy link
Contributor

@qutek qutek commented Jul 28, 2022

The commit 0a781dd changes the docker examples to use if..elif..else

it is working fine tor the with-docker example, but not working for the with-docker-compose and with-docker-multi-env examples due to a missing semicolon.

Fix #39085

Bug

  • Related issues linked using fixes #number
  • Integration tests added
  • Errors have helpful link attached, see contributing.md

Feature

  • Implements an existing feature request or RFC. Make sure the feature request has been accepted for implementation before opening a PR.
  • Related issues linked using fixes #number
  • Integration tests added
  • Documentation added
  • Telemetry added. In case of a feature if it's used or not.
  • Errors have helpful link attached, see contributing.md

Documentation / Examples

  • Make sure the linting passes by running pnpm lint
  • The examples guidelines are followed from our contributing doc

@qutek
fix: missing semicolon on Dockerfile
0dc7c7f 
The commit 0a781dd changes the docker examples to use 'if..elif..else'

it is working fine tor the 'with-docker' example, but not working for the 'with-docker-compose' and 'with-docker-multi-env' examples due to missing semicolon.

Fix: #39085
@ijjk ijjk added the examples Issue/PR related to examples label Jul 28, 2022
ijjk
ijjk approved these changes Jul 28, 2022
View reviewed changes
Copy link
Member

@ijjk ijjk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@kodiakhq kodiakhq bot merged commit 377fddf into vercel:canary Jul 28, 2022
@balazsorban44
Copy link
Member

I was going to open this PR, thanks for the quick fix! I am still wondering why would it work in one Dockerfile (with-docker) but not the other though. 🤔

@qutek
Copy link
Contributor Author

qutek commented Jul 29, 2022

@balazsorban44 my pleasure.

Yeah, seems like only with-docker-compose and with-docker-multi-env has missing semicolons, all good for the with-docker example

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 28, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@ijjk ijjk ijjk approved these changes

@timneutkens timneutkens Awaiting requested review from timneutkens

@shuding shuding Awaiting requested review from shuding

@leerob leerob Awaiting requested review from leerob

@steven-tey steven-tey Awaiting requested review from steven-tey

@balazsorban44 balazsorban44 Awaiting requested review from balazsorban44

Assignees
No one assigned
Labels
examples Issue/PR related to examples
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Docker example broken
3 participants
@qutek @balazsorban44 @ijjk