Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update turbo cache key #36074

Merged
merged 1 commit into from Apr 11, 2022
Merged

Update turbo cache key #36074

merged 1 commit into from Apr 11, 2022

Conversation

ijjk
Copy link
Member

@ijjk ijjk commented Apr 11, 2022

Seems we can download the wrong turbo cache depending on the target causing incorrect cache hits for example: https://github.com/vercel/next.js/runs/5976740062?check_suite_focus=true#step:16:11

@ijjk ijjk added the created-by: Next.js team PRs by the Next.js team label Apr 11, 2022
@ijjk ijjk requested a review from kdy1 April 11, 2022 19:12
@ijjk
Copy link
Member Author

ijjk commented Apr 11, 2022

Stats from current PR

Default Build (Decrease detected ✓)
General
vercel/next.js canary ijjk/next.js update/turbo-cache-key Change
buildDuration 15s 15s ⚠️ +27ms
buildDurationCached 5.9s 6s ⚠️ +95ms
nodeModulesSize 484 MB 484 MB
Page Load Tests Overall decrease ⚠️
vercel/next.js canary ijjk/next.js update/turbo-cache-key Change
/ failed reqs 0 0
/ total time (seconds) 3.016 3.004 -0.01
/ avg req/sec 828.8 832.11 +3.31
/error-in-render failed reqs 0 0
/error-in-render total time (seconds) 1.16 1.179 ⚠️ +0.02
/error-in-render avg req/sec 2155.58 2121.16 ⚠️ -34.42
Client Bundles (main, webpack)
vercel/next.js canary ijjk/next.js update/turbo-cache-key Change
925.HASH.js gzip 179 B 179 B
framework-HASH.js gzip 42 kB 42 kB
main-HASH.js gzip 28 kB 28 kB
webpack-HASH.js gzip 1.44 kB 1.44 kB
Overall change 71.7 kB 71.7 kB
Legacy Client Bundles (polyfills)
vercel/next.js canary ijjk/next.js update/turbo-cache-key Change
polyfills-HASH.js gzip 31 kB 31 kB
Overall change 31 kB 31 kB
Client Pages
vercel/next.js canary ijjk/next.js update/turbo-cache-key Change
_app-HASH.js gzip 1.36 kB 1.36 kB
_error-HASH.js gzip 192 B 192 B
amp-HASH.js gzip 309 B 309 B
css-HASH.js gzip 327 B 327 B
dynamic-HASH.js gzip 3.05 kB 3.05 kB
head-HASH.js gzip 351 B 351 B
hooks-HASH.js gzip 920 B 920 B
image-HASH.js gzip 5.68 kB 5.68 kB
index-HASH.js gzip 263 B 263 B
link-HASH.js gzip 2.32 kB 2.32 kB
routerDirect..HASH.js gzip 320 B 320 B
script-HASH.js gzip 387 B 387 B
withRouter-HASH.js gzip 319 B 319 B
85e02e95b279..7e3.css gzip 107 B 107 B
Overall change 15.9 kB 15.9 kB
Client Build Manifests
vercel/next.js canary ijjk/next.js update/turbo-cache-key Change
_buildManifest.js gzip 460 B 460 B
Overall change 460 B 460 B
Rendered Page Sizes
vercel/next.js canary ijjk/next.js update/turbo-cache-key Change
index.html gzip 531 B 531 B
link.html gzip 545 B 545 B
withRouter.html gzip 525 B 525 B
Overall change 1.6 kB 1.6 kB

Default Build with SWC (Decrease detected ✓)
General
vercel/next.js canary ijjk/next.js update/turbo-cache-key Change
buildDuration 18.2s 18.3s ⚠️ +83ms
buildDurationCached 6s 5.9s -68ms
nodeModulesSize 484 MB 484 MB
Page Load Tests Overall decrease ⚠️
vercel/next.js canary ijjk/next.js update/turbo-cache-key Change
/ failed reqs 0 0
/ total time (seconds) 3.029 3.006 -0.02
/ avg req/sec 825.39 831.72 +6.33
/error-in-render failed reqs 0 0
/error-in-render total time (seconds) 1.151 1.155 0
/error-in-render avg req/sec 2172.29 2164.12 ⚠️ -8.17
Client Bundles (main, webpack)
vercel/next.js canary ijjk/next.js update/turbo-cache-key Change
925.HASH.js gzip 178 B 178 B
framework-HASH.js gzip 42.3 kB 42.3 kB
main-HASH.js gzip 28.3 kB 28.3 kB
webpack-HASH.js gzip 1.45 kB 1.45 kB
Overall change 72.3 kB 72.3 kB
Legacy Client Bundles (polyfills)
vercel/next.js canary ijjk/next.js update/turbo-cache-key Change
polyfills-HASH.js gzip 31 kB 31 kB
Overall change 31 kB 31 kB
Client Pages
vercel/next.js canary ijjk/next.js update/turbo-cache-key Change
_app-HASH.js gzip 1.35 kB 1.35 kB
_error-HASH.js gzip 179 B 179 B
amp-HASH.js gzip 313 B 313 B
css-HASH.js gzip 325 B 325 B
dynamic-HASH.js gzip 3.03 kB 3.03 kB
head-HASH.js gzip 351 B 351 B
hooks-HASH.js gzip 921 B 921 B
image-HASH.js gzip 5.74 kB 5.74 kB
index-HASH.js gzip 261 B 261 B
link-HASH.js gzip 2.38 kB 2.38 kB
routerDirect..HASH.js gzip 322 B 322 B
script-HASH.js gzip 388 B 388 B
withRouter-HASH.js gzip 317 B 317 B
85e02e95b279..7e3.css gzip 107 B 107 B
Overall change 16 kB 16 kB
Client Build Manifests
vercel/next.js canary ijjk/next.js update/turbo-cache-key Change
_buildManifest.js gzip 459 B 459 B
Overall change 459 B 459 B
Rendered Page Sizes
vercel/next.js canary ijjk/next.js update/turbo-cache-key Change
index.html gzip 532 B 532 B
link.html gzip 545 B 545 B
withRouter.html gzip 527 B 527 B
Overall change 1.6 kB 1.6 kB
Commit: 1ce9bc9

@kodiakhq kodiakhq bot merged commit 5053026 into vercel:canary Apr 11, 2022
@ijjk ijjk deleted the update/turbo-cache-key branch April 11, 2022 19:38
@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 12, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
created-by: Next.js team PRs by the Next.js team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants