Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor default locale prefix to support clone() #35874

Merged
merged 5 commits into from Apr 6, 2022

Conversation

kamerat
Copy link
Contributor

@kamerat kamerat commented Apr 4, 2022

Bug

fixes #35273

  • Related issues linked using fixes #number
  • Integration tests added
  • Errors have helpful link attached, see contributing.md

Documentation / Examples

  • Make sure the linting passes by running yarn lint

Copy link
Member

@javivelasco javivelasco left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this! I think that for this example we don't need stripDefaultLocale anymore since that is already done by NextURL

@kamerat
Copy link
Contributor Author

kamerat commented Apr 6, 2022

I think that for this example we don't need stripDefaultLocale anymore since that is already done by NextURL

Cool, I did not know that. Removed it in e2b3f51. Not tested.

@kodiakhq kodiakhq bot merged commit 07723be into vercel:canary Apr 6, 2022
@kamerat kamerat deleted the patch-1 branch April 6, 2022 15:03
colinhacks pushed a commit to colinhacks/next.js that referenced this pull request Apr 14, 2022
## Bug
fixes vercel#35273

- [x] Related issues linked using `fixes #number`
- [ ] Integration tests added
- [ ] Errors have helpful link attached, see `contributing.md`


## Documentation / Examples

- [ ] Make sure the linting passes by running `yarn lint`
@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 7, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Docs: i18n doc needs to be updated for to use with url absolute & nextUrl clone
4 participants