Skip to content

Commit

Permalink
Remove buildId test as it's no longer relevant (#56316)
Browse files Browse the repository at this point in the history
Follow-up to #56310.
  • Loading branch information
timneutkens committed Oct 2, 2023
1 parent 86274e6 commit 98432a4
Show file tree
Hide file tree
Showing 5 changed files with 0 additions and 33 deletions.
9 changes: 0 additions & 9 deletions test/integration/config-mjs/next.config.mjs
Expand Up @@ -13,13 +13,4 @@ export default {
env: {
customVar: 'hello',
},
webpack(config, { buildId, webpack }) {
config.plugins.push(
new webpack.DefinePlugin({
'process.env.CONFIG_BUILD_ID': JSON.stringify(buildId),
})
)

return config
},
}
3 changes: 0 additions & 3 deletions test/integration/config-mjs/pages/build-id.js

This file was deleted.

6 changes: 0 additions & 6 deletions test/integration/config-mjs/test/index.test.js
Expand Up @@ -28,7 +28,6 @@ describe('Configuration', () => {
// pre-build all pages at the start
await Promise.all([
renderViaHTTP(context.appPort, '/next-config'),
renderViaHTTP(context.appPort, '/build-id'),
renderViaHTTP(context.appPort, '/module-only-component'),
])
})
Expand Down Expand Up @@ -58,11 +57,6 @@ describe('Configuration', () => {
expect($('#server-and-client').text()).toBe('/static')
})

test('renders the build id in development mode', async () => {
const $ = await get$('/build-id')
expect($('#buildId').text()).toBe('development')
})

test('correctly imports a package that defines `module` but no `main` in package.json', async () => {
const $ = await get$('/module-only-content')
expect($('#messageInAPackage').text()).toBe('OK')
Expand Down
9 changes: 0 additions & 9 deletions test/integration/config/next.config.js
Expand Up @@ -13,13 +13,4 @@ module.exports = {
env: {
customVar: 'hello',
},
webpack(config, { buildId, webpack }) {
config.plugins.push(
new webpack.DefinePlugin({
'process.env.CONFIG_BUILD_ID': JSON.stringify(buildId),
})
)

return config
},
}
6 changes: 0 additions & 6 deletions test/integration/config/test/index.test.js
Expand Up @@ -28,7 +28,6 @@ describe('Configuration', () => {
// pre-build all pages at the start
await Promise.all([
renderViaHTTP(context.appPort, '/next-config'),
renderViaHTTP(context.appPort, '/build-id'),
renderViaHTTP(context.appPort, '/module-only-component'),
])
})
Expand Down Expand Up @@ -58,11 +57,6 @@ describe('Configuration', () => {
expect($('#server-and-client').text()).toBe('/static')
})

test('renders the build id in development mode', async () => {
const $ = await get$('/build-id')
expect($('#buildId').text()).toBe('development')
})

test('correctly imports a package that defines `module` but no `main` in package.json', async () => {
const $ = await get$('/module-only-content')
expect($('#messageInAPackage').text()).toBe('OK')
Expand Down

0 comments on commit 98432a4

Please sign in to comment.