fix: handler assignment should be happened after super() call

unjs · Nov 4, 2018 · 150699d · 150699d
1 parent fc763a1
commit 150699d
Showing 1 changed file with 5 additions and 4 deletions.
diff --git a/src/plugin.js b/src/plugin.js
@@ -38,6 +38,11 @@ export default class WebpackBarPlugin extends ProgressPlugin {
     this.options = Object.assign({}, DEFAULTS, options);
     this.name = startCase(options.name);
 
+    // Assign a better handler to base ProgressPlugin
+    this.handler = (percent, message, ...details) => {
+      this.updateProgress(percent, message, details);
+    };
+
     // Keep our state in shared ojbect
     this.states = globalStates;
     if (!this.states[this.name]) {
@@ -153,10 +158,6 @@ export default class WebpackBarPlugin extends ProgressPlugin {
     });
   }
 
-  handler(percent, message, ...details) {
-    this.updateProgress(percent, message, details);
-  }
-
   updateProgress(percent = 0, message = '', details = []) {
     const progress = Math.floor(percent * 100);