Skip to content

Commit

Permalink
exit with 1 if husky fails to install/uninstall
Browse files Browse the repository at this point in the history
  • Loading branch information
typicode committed Dec 1, 2020
1 parent 38a7163 commit 033a2ae
Showing 1 changed file with 1 addition and 0 deletions.
1 change: 1 addition & 0 deletions src/installer/bin.ts
Original file line number Diff line number Diff line change
Expand Up @@ -108,6 +108,7 @@ function run(): void {
console.log(chalk.red(err.message.trim()))
debug(err.stack)
console.log(chalk.red(`husky > Failed to ${action}`))
process.exit(1)
}
}

Expand Down

1 comment on commit 033a2ae

@theoludwig
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In my opinion, It should not be the case, because we should continue to install others dependencies even if husky fails.
For example: inside a Docker Container, it fails but we don't care about husky so it should just continue and ignore the failure.
See #655 and #821.

Please sign in to comment.