Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: typescript-eslint/typescript-eslint
base: 43b1201a73687e29f19a16b0b26f68569f3c7a2e
Choose a base ref
...
head repository: typescript-eslint/typescript-eslint
compare: c51e3f0c7450481813348847c6d28b7589b0a92d
Choose a head ref
  • 18 commits
  • 164 files changed
  • 4 contributors

Commits on Aug 27, 2020

  1. Configuration menu
    Copy the full SHA
    a10d671 View commit details
    Browse the repository at this point in the history

Commits on Aug 29, 2020

  1. Configuration menu
    Copy the full SHA
    3854d6c View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    e9d2ab6 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    3be125d View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    c70f54f View commit details
    Browse the repository at this point in the history
  5. feat(eslint-plugin): [ban-ts-comment] change default for `ts-expect-e…

    …rror` to `allow-with-description` (#2351)
    
    BREAKING CHANGE:
    
    Default rule options is a breaking change.
    Fixes #2146
    bradzacher committed Aug 29, 2020
    Configuration menu
    Copy the full SHA
    a3f163a View commit details
    Browse the repository at this point in the history
  6. Configuration menu
    Copy the full SHA
    a9cd6fb View commit details
    Browse the repository at this point in the history
  7. Configuration menu
    Copy the full SHA
    9de669f View commit details
    Browse the repository at this point in the history
  8. fix: correct decorator traversal for AssignmentPattern (#2375)

    BREAKING CHANGE:
    - Removed decorators property from several Nodes that could never semantically have them (FunctionDeclaration, TSEnumDeclaration, and TSInterfaceDeclaration)
    - Removed AST_NODE_TYPES.Import. This is a minor breaking change as the node type that used this was removed ages ago.
    bradzacher committed Aug 29, 2020
    Configuration menu
    Copy the full SHA
    d738fa4 View commit details
    Browse the repository at this point in the history
  9. Configuration menu
    Copy the full SHA
    762bc99 View commit details
    Browse the repository at this point in the history
  10. Configuration menu
    Copy the full SHA
    58b1c2d View commit details
    Browse the repository at this point in the history
  11. feat(eslint-plugin): [no-unnecessary-condition][strict-boolean-expres…

    …sions] add option to make the rules error on files without `strictNullChecks` turned on (#2345)
    bradzacher committed Aug 29, 2020
    Configuration menu
    Copy the full SHA
    9273441 View commit details
    Browse the repository at this point in the history
  12. feat(typescript-estree): switch to globby (#2418)

    Fixes #2398
    
    If the user has a particularly large node_modules folder and uses globs for `parserOption.project`, then the `glob` library can spend a decent chunk of time searching the `node_modules` folder.
    In some cases, this can be on the order of hundreds to thousands of milliseconds.
    This wouldn't be a problem, but for safety and correctness during a persistent parse, we have to do this check for every call to the parser (i.e. every file that's being linted).
    Over a whole project, this can easily add up to many, many seconds wasted.
    
    Previously, we:
    - applied the project globs, one by one
    - then manually excluded `tsconfig`s from the list.
    
    This meant that we are always slow. I remember I did this because I had issues getting `glob`'s `ignore` option to work at all.
    
    ## The solution
    
    `globby` is a better glob library:
    - it accepts an array of globs, which saves us doing manual looping
    - it supports exclusion globs (globs prefixed with `!`), which  are evaluated as part of the glob process
    - it has caching built in by default
    
    This allows us to evaluate all of the `project` globs at once, as opposed to one at a time (so should be less duplicated work).
    This also allows us to evaluate the `projectFolderIgnoreList` at the same time as the `project` globs (so should be no useless work done).
    
    All of these together should cut the glob evaluation time down to ~50ms for the first parse, and ~2ms for each parse after that (due to caching).
    For comparison, previously, in bad cases we would spend ~3-500ms, per project, per parsed file.
    
    Example to illustrate how much faster this can potentially be:
    For a project that provides 2 globs and has 100 files.
    Before: 300ms * 2 * 100 = 60,000ms (60s)
    After: 50ms + 2 * 100 = 250ms
    
    This should also save a non-trival amount of time in other, more optimal setups.
    
    BREAKING CHANGE:
    - removes the ability to supply a `RegExp` to `projectFolderIgnoreList`, and changes the meaning of the string value from a regex to a glob.
    bradzacher committed Aug 29, 2020
    Configuration menu
    Copy the full SHA
    3a7ec9b View commit details
    Browse the repository at this point in the history
  13. Configuration menu
    Copy the full SHA
    cd84549 View commit details
    Browse the repository at this point in the history
  14. chore: update dependencies

    bradzacher committed Aug 29, 2020
    Configuration menu
    Copy the full SHA
    ac0defc View commit details
    Browse the repository at this point in the history
  15. Configuration menu
    Copy the full SHA
    c3a6c2a View commit details
    Browse the repository at this point in the history
  16. Configuration menu
    Copy the full SHA
    4ff8c43 View commit details
    Browse the repository at this point in the history

Commits on Aug 31, 2020

  1. chore: publish v4.0.0

    JamesHenry committed Aug 31, 2020
    Configuration menu
    Copy the full SHA
    c51e3f0 View commit details
    Browse the repository at this point in the history