fix(eslint-plugin): [no-unnecessary-type-assertion] handle missing d…

…eclarations (#537)
typescript-eslint · Jun 9, 2019 · c69f4b7 · c69f4b7
1 parent b16409a
commit c69f4b7
Show file tree

Hide file tree

Showing 3 changed files with 56 additions and 2 deletions.
diff --git a/packages/eslint-plugin/src/rules/no-unnecessary-type-assertion.ts b/packages/eslint-plugin/src/rules/no-unnecessary-type-assertion.ts
@@ -134,6 +134,11 @@ export default util.createRule<Options, MessageIds>({
      */
     function isPossiblyUsedBeforeAssigned(node: ts.Expression): boolean {
       const declaration = util.getDeclaration(checker, node);
+      if (!declaration) {
+        // don't know what the declaration is for some reason, so just assume the worst
+        return true;
+      }
+
       if (
         // non-strict mode doesn't care about used before assigned errors
         isStrictCompilerOptionEnabled(compilerOptions, 'strictNullChecks') &&

diff --git a/packages/eslint-plugin/src/util/types.ts b/packages/eslint-plugin/src/util/types.ts
@@ -140,8 +140,17 @@ export function isNullableType(
 export function getDeclaration(
   checker: ts.TypeChecker,
   node: ts.Expression,
-): ts.Declaration {
-  return checker.getSymbolAtLocation(node)!.declarations![0];
+): ts.Declaration | null {
+  const symbol = checker.getSymbolAtLocation(node);
+  if (!symbol) {
+    return null;
+  }
+  const declarations = symbol.declarations;
+  if (!declarations) {
+    return null;
+  }
+
+  return declarations[0];
 }
 
 /**

diff --git a/packages/eslint-plugin/tests/rules/no-unnecessary-type-assertion.test.ts b/packages/eslint-plugin/tests/rules/no-unnecessary-type-assertion.test.ts
@@ -95,6 +95,21 @@ declare const str: string | null;
 
 foo(str!);
     `,
+    // https://github.com/typescript-eslint/typescript-eslint/issues/532
+    `
+declare function a(a: string): any;
+declare const b: string | null;
+class Mx {
+  @a(b!)
+  private prop = 1;
+}
+    `,
+    `
+class Mx {
+  @a(b!)
+  private prop = 1;
+}
+    `,
   ],
 
   invalid: [
@@ -280,5 +295,30 @@ class Foo {
         },
       ],
     },
+    // https://github.com/typescript-eslint/typescript-eslint/issues/532
+    {
+      code: `
+declare function a(a: string): any;
+const b = 'asdf';
+class Mx {
+  @a(b!)
+  private prop = 1;
+}
+      `,
+      output: `
+declare function a(a: string): any;
+const b = 'asdf';
+class Mx {
+  @a(b)
+  private prop = 1;
+}
+      `,
+      errors: [
+        {
+          messageId: 'unnecessaryAssertion',
+          line: 5,
+        },
+      ],
+    },
   ],
 });