fix(eslint-plugin): [prefer-regexp-exec] check RegExp without flags (…

…#3946)
typescript-eslint · Oct 3, 2021 · 0868725 · 0868725
1 parent f8f534e
commit 0868725
Show file tree

Hide file tree

Showing 2 changed files with 28 additions and 0 deletions.
diff --git a/packages/eslint-plugin/src/rules/prefer-regexp-exec.ts b/packages/eslint-plugin/src/rules/prefer-regexp-exec.ts
@@ -84,6 +84,7 @@ export default createRule({
       ) {
         const [, flags] = node.arguments;
         return (
+          flags &&
           flags.type === AST_NODE_TYPES.Literal &&
           typeof flags.value === 'string' &&
           flags.value.includes('g')

diff --git a/packages/eslint-plugin/tests/rules/prefer-regexp-exec.test.ts b/packages/eslint-plugin/tests/rules/prefer-regexp-exec.test.ts
@@ -230,6 +230,33 @@ function test(pattern: string) {
       output: `
 function test(pattern: string) {
   new RegExp(pattern, undefined).exec('check');
+}
+      `,
+    },
+    {
+      // https://github.com/typescript-eslint/typescript-eslint/issues/3941
+      code: `
+function temp(text: string): void {
+  text.match(new RegExp(\`\${'hello'}\`));
+  text.match(new RegExp(\`\${'hello'.toString()}\`));
+}
+      `,
+      errors: [
+        {
+          messageId: 'regExpExecOverStringMatch',
+          line: 3,
+          column: 8,
+        },
+        {
+          messageId: 'regExpExecOverStringMatch',
+          line: 4,
+          column: 8,
+        },
+      ],
+      output: `
+function temp(text: string): void {
+  new RegExp(\`\${'hello'}\`).exec(text);
+  new RegExp(\`\${'hello'.toString()}\`).exec(text);
 }
       `,
     },