perf: improve SapQueryRunner performance (#10198)

Use async API exposed by SAP driver Co-authored-by: Lukasz Otczyk <lukasz.otczyk@nexontis.com>
typeorm · Dec 29, 2023 · f6b87e3 · f6b87e3
1 parent bafcd17
commit f6b87e3
Showing 1 changed file with 17 additions and 8 deletions.
diff --git a/src/driver/sap/SapQueryRunner.ts b/src/driver/sap/SapQueryRunner.ts
@@ -202,15 +202,24 @@ export class SapQueryRunner extends BaseQueryRunner implements QueryRunner {
             const queryStartTime = +new Date()
             const isInsertQuery = query.substr(0, 11) === "INSERT INTO"
 
-            statement = databaseConnection.prepare(query)
+            if (parameters?.some(Array.isArray)) {
+                statement = await promisify(
+                    databaseConnection.prepare.bind(databaseConnection),
+                )(query)
+            }
 
-            const raw = await new Promise<any>((ok, fail) => {
-                statement.exec(parameters, (err: any, raw: any) =>
-                    err
-                        ? fail(new QueryFailedError(query, parameters, err))
-                        : ok(raw),
-                )
-            })
+            let raw: any
+            try {
+                raw = statement
+                    ? await promisify(statement.exec.bind(statement))(
+                          parameters,
+                      )
+                    : await promisify(
+                          databaseConnection.exec.bind(databaseConnection),
+                      )(query, parameters, {})
+            } catch (err) {
+                throw new QueryFailedError(query, parameters, err)
+            }
 
             // log slow queries if maxQueryExecution time is set
             const maxQueryExecutionTime =