Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

updated table to be responsive #39663

Merged
merged 2 commits into from Feb 13, 2024
Merged

updated table to be responsive #39663

merged 2 commits into from Feb 13, 2024

Conversation

DrejT
Copy link
Contributor

@DrejT DrejT commented Feb 8, 2024

Description

add a responsive div to contain the table

Motivation & Context

Type of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Refactoring (non-breaking change)
  • Breaking change (fix or feature that would change existing functionality)

Checklist

  • I have read the contributing guidelines
  • My code follows the code style of the project (using npm run lint)
  • My change introduces changes to the documentation
  • I have updated the documentation accordingly
  • I have added tests to cover my changes
  • All new and existing tests passed

Live previews

Related issues

@DrejT
Copy link
Contributor Author

DrejT commented Feb 8, 2024

i am unaware with the working of worflows,
how do you run them?

@julien-deramond
Copy link
Member

Thanks for the PR @DrejT

i am unaware with the working of workflows,
how do you run them?

When you're a first contributor, running workflows must be validated by a maintainer. I can see that they are all green so someone has probably done it in the meantime. We'll try to look at your PR as soon as possible.

Copy link
Member

@julien-deramond julien-deramond left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch! The rendering is better on small screens thanks to the surrounding <div class="table-responsive">. LGTM!

Note: I've just added a commit to fix the formatting; the original modification (more readable in the diff 😇) is 440021c

@julien-deramond julien-deramond merged commit d30385b into twbs:main Feb 13, 2024
14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
No open projects
Status: Done
Development

Successfully merging this pull request may close these issues.

None yet

3 participants