Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix product example mobile navbar toggler #39657

Merged

Conversation

julien-deramond
Copy link
Member

@julien-deramond julien-deramond commented Feb 7, 2024

Description

This PR fixes the second issue described in #39656:

"Product example": when screen is small (mobile for example), menu does not work. I click the button but nothing happens.

Indeed, the IDs started with a "#" which caused an issue when referenced by data-bs-toggle.
Other references starting with a "#" were also wrong in this same document and have been fixed.

Type of changes

  • Bug fix (non-breaking change which fixes an issue)

Checklist

  • I have read the contributing guidelines
  • My code follows the code style of the project (using npm run lint)
  • My change introduces changes to the documentation
  • (N/A) I have updated the documentation accordingly
  • (N/A) I have added tests to cover my changes
  • All new and existing tests passed

Live previews

Related issues

Closes #39656

@julien-deramond julien-deramond force-pushed the main-jd-fix-product-example-offcanvas-mobile-toggle branch from 1242cf8 to d2b4066 Compare February 7, 2024 21:15
@julien-deramond julien-deramond marked this pull request as ready for review February 7, 2024 21:17
@julien-deramond julien-deramond merged commit 1bc85bf into main Feb 14, 2024
14 checks passed
@julien-deramond julien-deramond deleted the main-jd-fix-product-example-offcanvas-mobile-toggle branch February 14, 2024 20:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Bugs inside "Cover Template" and "Product Template"
3 participants