Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow dl, dt and dd in sanitizer #39376

Merged
merged 2 commits into from Nov 15, 2023
Merged

Allow dl, dt and dd in sanitizer #39376

merged 2 commits into from Nov 15, 2023

Conversation

Frenzie
Copy link
Contributor

@Frenzie Frenzie commented Nov 7, 2023 •
edited by julien-deramond

Motivation & Context

These are inoffensive regular elements, along the same lines as ol/ul with li. Overriding the defaults for that seems silly.

Type of changes

(I guess it's somewhere in the middle.)

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Refactoring (non-breaking change)
  • Breaking change (fix or feature that would change existing functionality)

Checklist

  • I have read the contributing guidelines
  • My code follows the code style of the project (using npm run lint)
  • My change introduces changes to the documentation
  • I have updated the documentation accordingly
  • I have added tests to cover my changes
  • All new and existing tests passed

Live previews

Related issues

#33827

@Frenzie
Allow dl, dt and dd in sanitizer
966f330 
These are inoffensive regular elements, along the same lines as ol/ul with li.
@Frenzie Frenzie requested a review from a team as a code owner November 7, 2023 12:52
@mdo
Copy link
Member

mdo commented Nov 13, 2023

Can't think of any reason to not include them. Thoughts @XhmikosR @GeoSot? Or @julien-deramond?

mdo
mdo approved these changes Nov 13, 2023
View reviewed changes
Copy link
Member

@mdo mdo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving conditionally while waiting on feedback.

julien-deramond
julien-deramond approved these changes Nov 14, 2023
View reviewed changes
Copy link
Member

@julien-deramond julien-deramond left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Agreed, can't think of a reason to not include them.

I've found this draft W3C Standard Proposal > HTML Sanitizer API where there's a section named The Baseline Element Allow List. These elements are mentioned in it too.

@julien-deramond julien-deramond merged commit b9f92d7 into twbs:main Nov 15, 2023
14 checks passed
@Frenzie Frenzie deleted the dl branch November 15, 2023 08:20
romankupchak93 pushed a commit to romankupchak93/bootstrap that referenced this pull request Jan 5, 2024
@Frenzie @julien-deramond @romankupchak93
Allow <dl>, <dt> and <dd> in JS sanitizer (twbs#39376)
a47c342 
Co-authored-by: Julien Déramond <juderamond@gmail.com>
@damian-snyk damian-snyk mentioned this pull request Apr 19, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mdo mdo mdo approved these changes

@julien-deramond julien-deramond julien-deramond approved these changes

Assignees
No one assigned
Labels
js v5
Projects
No open projects
v5.3.3
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@Frenzie @mdo @julien-deramond