Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Docs: fix for example code blocks have unnecessary 30px right-margin #39246

Merged
merged 2 commits into from Oct 5, 2023
Merged

Docs: fix for example code blocks have unnecessary 30px right-margin #39246

merged 2 commits into from Oct 5, 2023

Conversation

coliff
Copy link
Contributor

@coliff coliff commented Sep 27, 2023 •
edited

Description

Fixes: #39245

Motivation & Context

Explained in the linked issue

Type of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Refactoring (non-breaking change)
  • Breaking change (fix or feature that would change existing functionality)

Checklist

  • I have read the contributing guidelines
  • My code follows the code style of the project (using npm run lint)
  • My change introduces changes to the documentation
  • I have updated the documentation accordingly
  • I have added tests to cover my changes
  • All new and existing tests passed

Live previews

Related issues

@coliff coliff requested a review from a team as a code owner September 27, 2023 08:42
julien-deramond
julien-deramond approved these changes Sep 28, 2023
View reviewed changes
Copy link
Member

@julien-deramond julien-deramond left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks for the PR @coliff

/cc @mdo just to double-check if you don't remember about edge cases regarding this rendering. We created the docsref hidden page for that and everything seems OK even with this enhancement. If there are not edge cases, let's merge it.

@julien-deramond julien-deramond removed the request for review from mdo October 5, 2023 09:58
@julien-deramond julien-deramond merged commit 323f9d6 into twbs:main Oct 5, 2023
14 checks passed
@coliff coliff deleted the patch-3 branch October 5, 2023 11:15
romankupchak93 pushed a commit to romankupchak93/bootstrap that referenced this pull request Jan 5, 2024
@coliff @romankupchak93
Docs: fix unnecessary right-margin for example code blocks (twbs#39246)
2934114
@damian-snyk damian-snyk mentioned this pull request Apr 19, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@julien-deramond julien-deramond julien-deramond approved these changes

@louismaximepiton louismaximepiton louismaximepiton approved these changes

Assignees
No one assigned
Labels
docs enhancement v5
Projects
No open projects
v5.3.3
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Minor docs bug/issue: example code blocks have unnecessary 30px right-margin
3 participants
@coliff @julien-deramond @louismaximepiton