Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Suppress flexbox side effects in breadcrumb #31700

Merged
merged 3 commits into from Sep 29, 2020
Merged

Suppress flexbox side effects in breadcrumb #31700

merged 3 commits into from Sep 29, 2020

Conversation

MartijnCuppens
Copy link
Member

@MartijnCuppens MartijnCuppens commented Sep 18, 2020

#31692 will reintroduce this issue: https://codepen.io/francescomazzurco/pen/BaazRLY?editors=1100

By using a float, the inline spacing will disappear while we won't have the flexbox issue we currently have. A clearfix won't be needed, since there will always be content added in .breadcrumb-item

Fixes #31546
Closes #31692

@mdo
Copy link
Member

mdo commented Sep 18, 2020

Even better!

@mdo mdo added this to Inbox in v5.0.0-alpha3 via automation Sep 18, 2020
@mdo mdo removed this from Inbox in v5.0.0-alpha2 Sep 18, 2020
@mdo mdo added this to Inbox in v4.6.0 via automation Sep 18, 2020
v5.0.0-alpha3 automation moved this from Inbox to Approved Sep 18, 2020
Copy link
Member

@mdo mdo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Slating for Alpha 3 and v4.6.0.

@XhmikosR XhmikosR merged commit cda9278 into main Sep 29, 2020
v5.0.0-alpha3 automation moved this from Approved to Shipped Sep 29, 2020
@XhmikosR XhmikosR deleted the mc-main-breadcrumb branch September 29, 2020 18:32
@XhmikosR XhmikosR added the css label Sep 29, 2020
olsza pushed a commit to olsza/bootstrap that referenced this pull request Oct 3, 2020
* Suppress flexbox side effects

* Trailing whitesapce

Co-authored-by: Mark Otto <markd.otto@gmail.com>
Co-authored-by: XhmikosR <xhmikosr@gmail.com>
@XhmikosR XhmikosR moved this from Inbox to Needs manual backport in v4.6.0 Oct 19, 2020
@XhmikosR XhmikosR moved this from Needs manual backport to Cherry-picked/Manually backported in v4.6.0 Oct 26, 2020
XhmikosR added a commit that referenced this pull request Oct 26, 2020
* Suppress flexbox side effects

* Trailing whitesapce

Co-authored-by: Mark Otto <markd.otto@gmail.com>
Co-authored-by: XhmikosR <xhmikosr@gmail.com>
XhmikosR added a commit that referenced this pull request Oct 27, 2020
* Suppress flexbox side effects

* Trailing whitesapce

Co-authored-by: Mark Otto <markd.otto@gmail.com>
Co-authored-by: XhmikosR <xhmikosr@gmail.com>
XhmikosR added a commit that referenced this pull request Oct 27, 2020
* Suppress flexbox side effects

* Trailing whitesapce

Co-authored-by: Mark Otto <markd.otto@gmail.com>
Co-authored-by: XhmikosR <xhmikosr@gmail.com>
@XhmikosR XhmikosR moved this from Cherry-picked/Manually backported to Shipped in v4.6.0 Oct 27, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
No open projects
v4.6.0
Shipped
v5.0.0-alpha3
  
Shipped
Development

Successfully merging this pull request may close these issues.

v5: <sup> <sub> inconsistent styling
3 participants