Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Small improvement to configureHelp documentation #1858

Merged
merged 1 commit into from Mar 29, 2023
Merged

Small improvement to configureHelp documentation #1858

merged 1 commit into from Mar 29, 2023

Conversation

raineorshine
Copy link
Contributor

@raineorshine raineorshine commented Mar 29, 2023 •
edited

Pull Request

Problem

The full usage of configureHelp is not easy to find. The linked example only shows a few method overrides. There are mentions of the Help class, but a direct link would be much easier.

Solution

  • Added link to Help class in README.
  • Added link to Help class in configureHelp example.

shadowspawn
shadowspawn approved these changes Mar 29, 2023
View reviewed changes
Copy link
Collaborator

@shadowspawn shadowspawn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks.

abetomo
abetomo approved these changes Mar 29, 2023
View reviewed changes
Copy link
Collaborator

@abetomo abetomo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@abetomo abetomo merged commit ee78d95 into tj:develop Mar 29, 2023
11 checks passed
@shadowspawn shadowspawn added docs README (or other docs) could be improved pending release Merged into a branch for a future release, but not released yet labels Mar 30, 2023
@shadowspawn shadowspawn removed the pending release Merged into a branch for a future release, but not released yet label Apr 15, 2023
@shadowspawn
Copy link
Collaborator

Shipped in 10.0.1

Thanks @raineorshine

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@abetomo abetomo abetomo approved these changes

@shadowspawn shadowspawn shadowspawn approved these changes

Assignees
No one assigned
Labels
docs README (or other docs) could be improved
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@raineorshine @shadowspawn @abetomo