Assume a string parameter to implies is name of boolean option. #1854
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shadowspawn
added
the
pending release
shadowspawn
removed
the
pending release
|
Shipped in 10.0.1 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request
Problem
It is an easy mistake to pass a string to
.implies()instead of a hash. We have other routines that do just take option names, like.conflicts().See: #1852
Solution
Assume the users intent was to set the option to true, like a simple boolean option.
An alternative would be to throw an error, but that would probably need to wait for a semver major release since it would break programs that might otherwise be functional.
(Both of these were included as possible approaches in #1852.)
ChangeLog
(Leaving out of changelog as this is a quiet fixup rather than a feature as such.)