Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle errors despite timeouts #71

Merged
merged 2 commits into from Dec 16, 2020

Conversation

cdeevfrr
Copy link
Contributor

@cdeevfrr cdeevfrr commented Nov 5, 2019

Closes #70

@codecov
Copy link

codecov bot commented Nov 5, 2019

Codecov Report

Merging #71 into master will increase coverage by 0.06%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #71      +/-   ##
==========================================
+ Coverage    90.2%   90.27%   +0.06%     
==========================================
  Files           2        2              
  Lines         143      144       +1     
==========================================
+ Hits          129      130       +1     
  Misses         14       14
Impacted Files Coverage Δ
lib/retry_operation.js 86.17% <100%> (+0.14%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 88548b9...e3865c7. Read the comment docs.

@cdeevfrr
Copy link
Contributor Author

cdeevfrr commented Mar 3, 2020

Has anyone had a chance to look at this?

@tim-kos
Copy link
Owner

tim-kos commented Mar 4, 2020 via email

@tim-kos
Copy link
Owner

tim-kos commented Dec 16, 2020

Great, thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Include previous error even if there's a timeout
2 participants