fix(createError): separate createError into own module

lib/createError.js

@@ -0,0 +1,21 @@
+'use strict';
+var PluginError = require('gulp-util/lib/PluginError');
+var pluginName = 'gulp-uglify';
+
+module.exports = function createError(file, err) {
+  if (typeof err === 'string') {
+    return new PluginError(pluginName, file.path + ': ' + err, {
+      fileName: file.path,
+      showStack: false
+    });
+  }
+
+  var msg = err.message || err.msg || 'unspecified error';
+
+  return new PluginError(pluginName, file.path + ': ' + msg, {
+    fileName: file.path,
+    lineNumber: err.line,
+    stack: err.stack,
+    showStack: false
+  });
+};

minifier.js

@@ -6,8 +6,9 @@ var log = require('fancy-log');
 var applySourceMap = require('vinyl-sourcemaps-apply');
 var saveLicense = require('uglify-save-license');
 var isObject = require('isobject');
+var createError = require('./lib/createError');
+
 var reSourceMapComment = /\n\/\/# sourceMappingURL=.+?$/;
-var pluginName = 'gulp-uglify';
 
 function trycatch(fn, handle) {
   try {
@@ -42,24 +43,6 @@ function setup(opts) {
   return options;
 }
 
-function createError(file, err) {
-  if (typeof err === 'string') {
-    return new PluginError(pluginName, file.path + ': ' + err, {
-      fileName: file.path,
-      showStack: false
-    });
-  }
-
-  var msg = err.message || err.msg || 'unspecified error';
-
-  return new PluginError(pluginName, file.path + ': ' + msg, {
-    fileName: file.path,
-    lineNumber: err.line,
-    stack: err.stack,
-    showStack: false
-  });
-}
-
 module.exports = function (opts, uglify) {
   function minify(file, encoding, callback) {
     var options = setup(opts || {});

test/createError.js

@@ -0,0 +1,21 @@
+'use strict';
+var test = require('tape');
+var Vinyl = require('vinyl');
+var createError = require('../lib/createError');
+
+var testOkContentsInput = '"use strict"; (function(console, first, second) { console.log(first + second) }(5, 10))';
+var testFile = new Vinyl({
+  cwd: '/home/terin/broken-promises/',
+  base: '/home/terin/broken-promises/test',
+  path: '/home/terin/broken-promises/test/test2.js',
+  contents: new Buffer(testOkContentsInput)
+});
+
+test('should report "unspecified error" if err has no msg or message properties', function (t) {
+  t.plan(3);
+  var e = createError(testFile, {});
+
+  t.ok(e instanceof Error, 'argument should be of type error');
+  t.equal(e.plugin, 'gulp-uglify', 'error is from gulp-uglify');
+  t.true(e.message.match(/unspecified error$/), 'error should not be specified');
+});