Simplify Popover Tab logic by using sentinel nodes instead of keydown event interception
#1440
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Use `TabSentinel` instead of intercepting the `Tab` keydown events.
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
This was referenced May 12, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR will simplify the
Popovercomponent by using the same strategy we applied in theFocusTrapcomponent.This uses sentinel DOM nodes instead of
keydownevent interception and manually trying to focusthe next element. This improves a bunch of subtle bugs because now the browser will handle all of
the Tab related logic. This means that it fixes the following bugs for free:
Fixes: #1215
Fixes: #1140
Fixes: #467