Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(types): remove the readonly modifier from 'SweetAlertOptions' #1996

Merged
merged 1 commit into from Jun 8, 2020
Merged

fix(types): remove the readonly modifier from 'SweetAlertOptions' #1996

merged 1 commit into from Jun 8, 2020

Conversation

rafaelss95
Copy link
Contributor

@rafaelss95 rafaelss95 commented Jun 8, 2020 •
edited by limonte

@rafaelss95
Copy link
Contributor Author

rafaelss95 commented Jun 8, 2020 •
edited

@limonte @toverux can I add the readonly modifier for the non updatable parameters?

Not really related to this PR, but navigating deep into the code, I found this comment:

sweetalert2/src/instanceMethods/update.js

Line 14 in 88c4ae9

return warn(`You're trying to update the closed or closing popup, that won't work. Use the update() method in preConfirm parameter or show a new popup.`)

Is it outdated, right? Because I can't update preConfirm via update...

@limonte
Copy link
Member

limonte commented Jun 8, 2020 •
edited

Is it outdated, right? Because I can't update preConfirm via update...

No, it's not outdated. It's this one: #1778

@rafaelss95
Copy link
Contributor Author

Is it outdated, right? Because I can't update preConfirm via update...

No, it's not outdated. It's this one: #1778

Ahhh, got it!! :)

@limonte
Copy link
Member

limonte commented Jun 8, 2020

@limonte @toverux can I add the readonly modifier for the non updatable parameters?

I don't have any opinion here, but if you think that should be done please go ahead with the PR, I'd be happy to review it!

limonte
limonte approved these changes Jun 8, 2020
View reviewed changes
Copy link
Member

@limonte limonte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @rafaelss95!

@limonte limonte merged commit 12fbea0 into sweetalert2:master Jun 8, 2020
@rafaelss95 rafaelss95 deleted the fix/rollback-readonly branch June 8, 2020 17:30
limonte pushed a commit that referenced this pull request Jun 8, 2020
@semantic-release-bot
chore(release): 9.14.3 [skip ci]
09d00a6 
## [9.14.3](v9.14.2...v9.14.3) (2020-06-08)

### Bug Fixes

* **types:** remove the readonly modifier from 'SweetAlertOptions' ([#1996](#1996)) ([12fbea0](12fbea0))
@limonte
Copy link
Member

limonte commented Jun 8, 2020

🎉 This PR is included in version 9.14.3 🎉

The release is available on:

Your semantic-release bot 📦🚀

@rafaelss95 rafaelss95 mentioned this pull request Jun 8, 2020
Merged
@Basaingeal Basaingeal mentioned this pull request Jun 9, 2020
Merged
matvejs16 pushed a commit to matvejs16/sweetalert2-fix that referenced this pull request Mar 29, 2023
@rafaelss95 @limonte
fix(types): remove the readonly modifier from 'SweetAlertOptions' (sw…
74c630b 
…eetalert2#1996)
matvejs16 pushed a commit to matvejs16/sweetalert2-fix that referenced this pull request Mar 29, 2023
@semantic-release-bot
chore(release): 9.14.3 [skip ci]
0e559b5 
## [9.14.3](sweetalert2/sweetalert2@v9.14.2...v9.14.3) (2020-06-08)

### Bug Fixes

* **types:** remove the readonly modifier from 'SweetAlertOptions' ([sweetalert2#1996](sweetalert2#1996)) ([74c630b](sweetalert2@74c630b))
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@limonte limonte limonte approved these changes

Assignees
No one assigned
Labels
released
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@rafaelss95 @limonte