feat: make close button updatable (#2018)

sweetalert2 · Jul 14, 2020 · 911394f · 911394f
1 parent 415c6c6
commit 911394f
Show file tree

Hide file tree

Showing 3 changed files with 11 additions and 2 deletions.
diff --git a/cypress/integration/methods/update.spec.js b/cypress/integration/methods/update.spec.js
@@ -25,7 +25,8 @@ describe('update()', () => {
       showConfirmButton: false,
       showCancelButton: true,
       cancelButtonText: 'New cancel button text',
-      imageUrl: '/assets/swal2-logo.png'
+      imageUrl: '/assets/swal2-logo.png',
+      showCloseButton: true,
     })
 
     expect(Swal.getTitle().textContent).to.equal('New title')
@@ -40,6 +41,8 @@ describe('update()', () => {
     expect(isVisible(Swal.getConfirmButton())).to.be.false
     expect(isVisible(Swal.getCancelButton())).to.be.true
     expect(Swal.getCancelButton().textContent).to.equal('New cancel button text')
+
+    expect(isVisible(Swal.getCloseButton())).to.be.true
   })
 
   it('update customClass', () => {

diff --git a/src/utils/params.js b/src/utils/params.js
@@ -98,6 +98,9 @@ export const updatableParams = [
   'cancelButtonColor',
   'buttonsStyling',
   'reverseButtons',
+  'showCloseButton',
+  'closeButtonHtml',
+  'closeButtonAriaLabel',
   'imageUrl',
   'imageWidth',
   'imageHeight',

diff --git a/test/qunit/methods/update.js b/test/qunit/methods/update.js
@@ -25,7 +25,8 @@ QUnit.test('update() method', (assert) => {
     showConfirmButton: false,
     showCancelButton: true,
     cancelButtonText: 'New cancel button text',
-    imageUrl: '/assets/swal2-logo.png'
+    imageUrl: '/assets/swal2-logo.png',
+    showCloseButton: true,
   })
 
   assert.equal(Swal.getTitle().textContent, 'New title')
@@ -40,6 +41,8 @@ QUnit.test('update() method', (assert) => {
   assert.notOk(isVisible(Swal.getConfirmButton()))
   assert.ok(isVisible(Swal.getCancelButton()))
   assert.equal(Swal.getCancelButton().textContent, 'New cancel button text')
+
+  assert.ok(isVisible(Swal.getCloseButton()))
 })
 
 QUnit.test('update customClass', (assert) => {