Listening for DOMContent loaded only if page state is 'loading' for oauth2-redirect.html #7828
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Forcing execution of the oauth-redirect.html
run
function after DOMContentLoaded is fired.Motivation and Context
I've encountered an issue trying to authorize to the API that is hosted behind CloudFlare and is using Cloudflare’s Browser Insights which injects
beacon.js
file which finishes loading after DOM is loaded. So therun
function couldn't be executed whenDOMContentLoaded
event is fired.This change uses code from StackOverflow question answer
How Has This Been Tested?
I was redirected having Cloudflare's beacon.js injected on the deployed server
Screenshots (if appropriate):
Checklist
My PR contains...
src/
is unmodified: changes to documentation, CI, metadata, etc.)package.json
)My changes...
Documentation
Automated tests