Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(serverVariables): refresh state on definition change #7821

Merged
merged 2 commits into from Feb 1, 2022

Conversation

tim-lai
Copy link
Contributor

@tim-lai tim-lai commented Feb 1, 2022

Description

In the servers component, add a check to compare the default values of the the server variables between previous and next props. If there is a difference, this suggests a change in definitions, so apply a new default value that will overwrite a user selected value from the previous definition. Note that it is possible for both the server variable keys and values to be equal across different definitions.

Motivation and Context

fixes #7392

How Has This Been Tested?

New Cypress E2E tests

Screenshots (if appropriate):

https://recordit.co/RguJjDkPF5

Checklist

My PR contains...

  • No code changes (src/ is unmodified: changes to documentation, CI, metadata, etc.)
  • Dependency changes (any modification to dependencies in package.json)
  • Bug fixes (non-breaking change which fixes an issue)
  • Improvements (misc. changes to existing features)
  • Features (non-breaking change which adds functionality)

My changes...

  • are breaking changes to a public API (config options, System API, major UI change, etc).
  • are breaking changes to a private API (Redux, component props, utility functions, etc.).
  • are breaking changes to a developer API (npm script behavior changes, new dev system dependencies, etc).
  • are not breaking changes.

Documentation

  • My changes do not require a change to the project documentation.
  • My changes require a change to the project documentation.
  • If yes to above: I have updated the documentation accordingly.

Automated tests

  • My changes can not or do not need to be tested.
  • My changes can and should be tested by unit and/or integration tests.
  • If yes to above: I have added tests to cover my changes.
  • If yes to above: I have taken care to cover edge cases in my tests.
  • All new and existing tests passed.

@tim-lai tim-lai changed the title Fix/7392 server variables fix(serverVariables): refresh state on definition change Feb 1, 2022
@tim-lai tim-lai merged commit a0e9923 into swagger-api:master Feb 1, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

"Server variables" not shown when switching between definitions
1 participant