Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Regression: Auth config not initialized and causing SwaggerUI crashes #7814

Closed
char0n opened this issue Jan 31, 2022 · 1 comment
Closed

Regression: Auth config not initialized and causing SwaggerUI crashes #7814

char0n opened this issue Jan 31, 2022 · 1 comment
Assignees
@char0n
Labels
type: regression version: 4.x

Comments

@char0n
Copy link
Member

char0n commented Jan 31, 2022 •
edited

Regression was introduced in c6d8d77 and our tests didn't catch it.

There is already a precedence code how to avoid no value returned by the selector here:

swagger-ui/src/core/components/auth/oauth2.jsx

Line 24 in c6d8d77

let authConfigs = authSelectors.getConfigs() || {}

I'll use the same pattern.
@char0n char0n self-assigned this Jan 31, 2022
char0n added a commit that referenced this issue Jan 31, 2022
@char0n
fix(auth): compensate for uninitialized config
51edfb6 
Refs #7814
@char0n char0n mentioned this issue Jan 31, 2022
Merged
17 tasks
char0n added a commit that referenced this issue Jan 31, 2022
@char0n
fix(auth): compensate for uninitialized config
6c10e4a 
Refs #7814
@char0n char0n closed this as completed Jan 31, 2022
@char0n
Copy link
Member Author

char0n commented Jan 31, 2022

Going for emergency 4.4.1 release as this makes using auth plugin unsable.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@char0n char0n

Labels
type: regression version: 4.x
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@char0n