Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

core.util.memoize usage #7800

Closed
char0n opened this issue Jan 26, 2022 · 0 comments
Closed

core.util.memoize usage #7800

char0n opened this issue Jan 26, 2022 · 0 comments
Assignees
@char0n
Labels
type: bug version: 4.x

Comments

@char0n
Copy link
Member

char0n commented Jan 26, 2022

This function creates cache key just from the first argument. So every place this function is used, we need to use either custom resolver function or memoizeN introduced in #7799
@char0n char0n self-assigned this Jan 26, 2022
char0n added a commit that referenced this issue Jan 26, 2022
@char0n
fix(view-plugin): provide resolvers for memoized functions
accedff 
Refs #7800
@char0n char0n mentioned this issue Jan 26, 2022
Merged
17 tasks
char0n added a commit that referenced this issue Jan 26, 2022
@char0n
fix(view-plugin): provide resolvers for memoized functions
6f66337 
Refs #7800
char0n added a commit that referenced this issue Jan 27, 2022
@char0n
fix(view-plugin): provide resolvers for memoized functions (#7801)
d638e58 
Before this change, memoization happened only on first
argument provided to the functions. Now the memoization
properly handle all arguments.

Refs #7800
@char0n char0n closed this as completed Jan 27, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@char0n char0n

Labels
type: bug version: 4.x
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@char0n