Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(highlight-code): handle mousewheel events properly #7554

Merged
merged 5 commits into from Oct 12, 2021

Conversation

char0n
Copy link
Member

@char0n char0n commented Oct 12, 2021

Refs #7497

Description

Motivation and Context

How Has This Been Tested?

Screenshots (if appropriate):

Checklist

My PR contains...

  • No code changes (src/ is unmodified: changes to documentation, CI, metadata, etc.)
  • Dependency changes (any modification to dependencies in package.json)
  • Bug fixes (non-breaking change which fixes an issue)
  • Improvements (misc. changes to existing features)
  • Features (non-breaking change which adds functionality)

My changes...

  • are breaking changes to a public API (config options, System API, major UI change, etc).
  • are breaking changes to a private API (Redux, component props, utility functions, etc.).
  • are breaking changes to a developer API (npm script behavior changes, new dev system dependencies, etc).
  • are not breaking changes.

Documentation

  • My changes do not require a change to the project documentation.
  • My changes require a change to the project documentation.
  • If yes to above: I have updated the documentation accordingly.

Automated tests

  • My changes can not or do not need to be tested.
  • My changes can and should be tested by unit and/or integration tests.
  • If yes to above: I have added tests to cover my changes.
  • If yes to above: I have taken care to cover edge cases in my tests.
  • All new and existing tests passed.

Copy link
Contributor

@mathis-m mathis-m left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

src/core/components/highlight-code.jsx Outdated Show resolved Hide resolved
src/core/components/highlight-code.jsx Outdated Show resolved Hide resolved
src/core/components/highlight-code.jsx Outdated Show resolved Hide resolved
src/core/components/highlight-code.jsx Outdated Show resolved Hide resolved
src/core/components/highlight-code.jsx Outdated Show resolved Hide resolved
src/core/components/highlight-code.jsx Outdated Show resolved Hide resolved
src/core/components/highlight-code.jsx Outdated Show resolved Hide resolved
Copy link
Contributor

@mathis-m mathis-m left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

code-compiles-ship-it

@char0n
Copy link
Member Author

char0n commented Oct 12, 2021

This needs to be adapted to release/4.x branch after the merge. Be aware that release/4.x branch is using React@17.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants