Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

support curl binary data when body type: string format: binary or base64 #7545

Merged
merged 3 commits into from Jan 31, 2022

Conversation

mathis-m
Copy link
Contributor

@mathis-m mathis-m commented Oct 7, 2021

Description

Have added request snippets generation case when body is win.File => --data-binary '@{file name}'

Motivation and Context

Fixes #7544

How Has This Been Tested?

unit

Screenshots (if appropriate):

image

Checklist

My PR contains...

  • No code changes (src/ is unmodified: changes to documentation, CI, metadata, etc.)
  • Dependency changes (any modification to dependencies in package.json)
  • Bug fixes (non-breaking change which fixes an issue)
  • Improvements (misc. changes to existing features)
  • Features (non-breaking change which adds functionality)

My changes...

  • are breaking changes to a public API (config options, System API, major UI change, etc).
  • are breaking changes to a private API (Redux, component props, utility functions, etc.).
  • are breaking changes to a developer API (npm script behavior changes, new dev system dependencies, etc).
  • are not breaking changes.

Documentation

  • My changes do not require a change to the project documentation.
  • My changes require a change to the project documentation.
  • If yes to above: I have updated the documentation accordingly.

Automated tests

  • My changes can not or do not need to be tested.
  • My changes can and should be tested by unit and/or integration tests.
  • If yes to above: I have added tests to cover my changes.
  • If yes to above: I have taken care to cover edge cases in my tests.
  • All new and existing tests passed.

@char0n char0n self-requested a review October 8, 2021 13:56
@char0n char0n self-assigned this Oct 8, 2021
@slandelle
Copy link

Hi there,
We reported this issue beginning of last October, @mathis-m was awesome and provided a PR within 24 hours and it's been stuck since then :(
Is there anything we can help with for making this PR moving forward?
Cheers

@mathis-m
Copy link
Contributor Author

@tim-lai can you have a look please :)

@tim-lai tim-lai merged commit 2b30a34 into swagger-api:master Jan 31, 2022
@tim-lai
Copy link
Contributor

tim-lai commented Jan 31, 2022

@mathis-m looks good to me, thanks for the ping. PR merged! The one concern I have is that I not sure "Execute" will work in this scenario (via swagger-client), but if needed, that can be a separate issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Incorrect curl command for file upload (without multipart/form-data)
4 participants