Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove redundant whitespaces on the api key auth popup #7538

Merged
merged 2 commits into from Oct 8, 2021

Conversation

hankovich
Copy link
Contributor

@hankovich hankovich commented Oct 5, 2021

Description

On the API key auth popup 2 spaces are displayed between Bearer and (apiKey). Usually I just copy paste Bearer (apiKey) from the popup to the textbox and the replace (apiKey) with the actual bearer token. Of cource, my requests receive 401 because the server interprets additional space as the token's first character. This PR removes extra whitespaces.

Screenshots (if appropriate):

image
image

Checklist

My PR contains...

  • No code changes (src/ is unmodified: changes to documentation, CI, metadata, etc.)
  • Dependency changes (any modification to dependencies in package.json)
  • Bug fixes (non-breaking change which fixes an issue)
  • Improvements (misc. changes to existing features)
  • Features (non-breaking change which adds functionality)

My changes...

  • are breaking changes to a public API (config options, System API, major UI change, etc).
  • are breaking changes to a private API (Redux, component props, utility functions, etc.).
  • are breaking changes to a developer API (npm script behavior changes, new dev system dependencies, etc).
  • are not breaking changes.

Documentation

  • My changes do not require a change to the project documentation.
  • My changes require a change to the project documentation.
  • If yes to above: I have updated the documentation accordingly.

Automated tests

  • My changes can not or do not need to be tested.
  • My changes can and should be tested by unit and/or integration tests.
  • If yes to above: I have added tests to cover my changes.
  • If yes to above: I have taken care to cover edge cases in my tests.
  • All new and existing tests passed.

@hankovich hankovich changed the title Remove redundant whitespaces in api key auth popup Remove redundant whitespaces on the api key auth popup Oct 5, 2021
Copy link
Contributor

@mathis-m mathis-m left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good

@hankovich
Copy link
Contributor Author

@char0n Could you view the PR?

Copy link
Member

@char0n char0n left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Right, look LEGIT!

Thanks for contributing.

@char0n char0n merged commit a740f3d into swagger-api:master Oct 8, 2021
@char0n
Copy link
Member

char0n commented Oct 8, 2021

@mathis-m thanks for the second pairs of eyes here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants