Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(style): update the buttons of the example tabs to be displayed as links #7517

Merged
merged 1 commit into from Sep 21, 2021
Merged

fix(style): update the buttons of the example tabs to be displayed as links #7517

merged 1 commit into from Sep 21, 2021

Conversation

dhenneke
Copy link
Contributor

Description

#7464 changed the tabs in the example section from links to buttons to improve the accessibility. This PR changes the styles of the buttons so they look like the old links:

Before

image

After

image

Checklist

My PR contains...

  • No code changes (src/ is unmodified: changes to documentation, CI, metadata, etc.)
  • Dependency changes (any modification to dependencies in package.json)
  • Bug fixes (non-breaking change which fixes an issue)
  • Improvements (misc. changes to existing features)
  • Features (non-breaking change which adds functionality)

My changes...

  • are breaking changes to a public API (config options, System API, major UI change, etc).
  • are breaking changes to a private API (Redux, component props, utility functions, etc.).
  • are breaking changes to a developer API (npm script behavior changes, new dev system dependencies, etc).
  • are not breaking changes.

Documentation

  • My changes do not require a change to the project documentation.
  • My changes require a change to the project documentation.
  • If yes to above: I have updated the documentation accordingly.

Automated tests

  • My changes can not or do not need to be tested.
  • My changes can and should be tested by unit and/or integration tests.
  • If yes to above: I have added tests to cover my changes.
  • If yes to above: I have taken care to cover edge cases in my tests.
  • All new and existing tests passed.

@char0n
Copy link
Member

char0n commented Sep 20, 2021

please build

@char0n
Copy link
Member

char0n commented Sep 20, 2021

@dhenneke Thanks!

I've tested this manually before it went to master, but unfortunately I didn't use "Incognito Window" to eliminate all cached files. Glad we have you to spot it and fix it in no time ;]

@char0n
Copy link
Member

char0n commented Sep 20, 2021

I'm afraid this change is not enough. The black accent of the font is much stronger than it was before. Needs to investigate further and have buttons look exactly like a links.

Screenshot_2021-09-20_18-59-02

This is how it used to look like:

Screenshot_2021-09-20_19-00-41

@char0n char0n mentioned this pull request Sep 20, 2021
17 tasks
@dhenneke
Copy link
Contributor Author

I assume that the color is not propagated to the button:
image

@dhenneke
Copy link
Contributor Author

Yep. When I add the color it looks better:

Without color

image

With color

image

src/style/_layout.scss Outdated Show resolved Hide resolved
src/style/_layout.scss Outdated Show resolved Hide resolved
Copy link
Member

@char0n char0n left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks for contributing! Have a look at my last comment regarding making the button selector more specific

@char0n
Copy link
Member

char0n commented Sep 21, 2021

Tested in incognito window now to verify regression is gone ;]

@char0n char0n merged commit ff5deb3 into swagger-api:master Sep 21, 2021
@char0n
Copy link
Member

char0n commented Sep 21, 2021

Thanks again!

@dhenneke dhenneke deleted the feat/example-buttons branch September 21, 2021 12:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants