New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: break path w/ <wbr>s to avoid copying ZWSPs #7516
Conversation
- Use <wbr> instead of ZERO-WIDTH SPACE (U+200B) to break segments in operation-summary-path.jsx - Remove no-longer-needed onCopyCapture listener which previously stripped ZWSPs Closes swagger-api#7513
4f7ae74
to
31f2a0f
Compare
- Use <wbr> instead of ZERO-WIDTH SPACE (U+200B) to break segments in operation-summary-path.jsx - Remove no-longer-needed onCopyCapture listener which previously stripped ZWSPs Closes swagger-api#7513
31f2a0f
to
ab79e52
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the PR!
You did a great job. Can you please look at my code review comments before we move forward?
- Use <wbr> instead of ZERO-WIDTH SPACE (U+200B) to break segments in operation-summary-path.jsx - Remove no-longer-needed onCopyCapture listener which previously stripped ZWSPs - Update's deep-link.jsx's `text` prop type to accept `PropType.node` to allow the above. Closes swagger-api#7513
ab79e52
to
b1ecfe1
Compare
Seems there is a warning I need to fix
Probably a pretty basic react thing |
- Use <wbr> instead of ZERO-WIDTH SPACE (U+200B) to break segments in operation-summary-path.jsx - Remove no-longer-needed onCopyCapture listener which previously stripped ZWSPs - Update's deep-link.jsx's `text` prop type to accept `PropType.node` to allow the above. Closes swagger-api#7513
b1ecfe1
to
0a84dbb
Compare
Replacing pathParts.splice(i, 0, <wbr />) with pathParts.splice(i, 0, <wbr key={i} />) Fixed the above. I guess this was in the original version of this PR too, just didn't notice. Ready for another review. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We're looking good here. Thank you for your contribution!
Thanks! 🎉 |
Description
operation-summary-path.jsx
stripped ZWSPs
Motivation and Context
Fixes #7513
How Has This Been Tested?
Basic local test, HTML looks right and behaves the same as before, just without copying of ZWSPs.
Screenshots (if appropriate):
N/A
Checklist
My PR contains...
src/
is unmodified: changes to documentation, CI, metadata, etc.)package.json
)My changes...
Documentation
Automated tests