New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Console error on scroll: Unable to preventDefault inside passive event listener due to target being treated as passive #7497

Closed

kristina-kovacikova-acn opened this issue Sep 14, 2021 · 6 comments · Fixed by #7519

Assignees

Labels

cat: user experience type: bug version: 3.x version: 4.x

kristina-kovacikova-acn commented Sep 14, 2021

OS: [windows, mac]
Browser: [chrome, edge]
Swagger-Editor version: 3.52.2
Swagger/OpenAPI version: [OpenAPI 3.0.3]

Description of the issue

When scrolling "Example value" = inside class .highlight-code the following error is thrown in the browser's console
[Intervention] Unable to preventDefault inside passive event listener due to target being treated as passive. See https://www.chromestatus.com/features/6662647093133312

Steps to reproduce

Copy past OpenAPI definition from the file above into https://editor.swagger.io/
collapse /pet endpoint
open console in the dev tools
scroll inside body -> example value -> error will be shown in the console

The text was updated successfully, but these errors were encountered:

char0n self-assigned this

Member

char0n commented Sep 15, 2021

Hi @kristina-kovacikova-acn,

Thanks for reporting this. Would you be willing to entertain investigating this issue and providing a fix for it via PR?

Author

kristina-kovacikova-acn commented Sep 17, 2021 •

edited

sure. I can investigate the issue and provide PR.

Member

char0n commented Sep 17, 2021

@kristina-kovacikova-acn great!

char0n added cat: user experience type: bug version: 3.x version: 4.x labels

kristina-kovacikova added a commit to kristina-kovacikova/swagger-ui that referenced this issue


          fix: highlight code scroll console error (swagger-api#7497)

c4c72ec

kristina-kovacikova mentioned this issue

fix: highlight code scroll console error (#7497) #7519

Merged

17 tasks

kristina-kovacikova added a commit to kristina-kovacikova/swagger-ui that referenced this issue


          fix: add condition in componentwillunmount (swagger-api#7497)

eec504c

char0n closed this as completed in #7519

char0n pushed a commit that referenced this issue


          fix: fix issue with highlight code scrolling causing console error (#…

24aaa53

…7497) (#7519)

Co-authored-by: Mahtis Michel <mathis.michel@outlook.de>

Refs #7497

char0n added a commit that referenced this issue


          refactor(highlight-code): declare properties explicitly

b7b79bb

Refs #7497

char0n mentioned this issue

refactor(highlight-code): declare properties explicitly #7537

Merged

17 tasks

char0n added a commit that referenced this issue


          refactor(highlight-code): declare properties explicitly

491d641

Refs #7497

char0n added a commit that referenced this issue


          refactor(highlight-code): add UNSAFE prefix for lifecycle methods

227b932

Refs #7497

mathis-m mentioned this issue

fix(syntax-highlight): fix of fix that caused highlight code scrolling errors #7553

Closed

17 tasks

char0n added a commit that referenced this issue


          fix(highlight-code): handle mousewheel events properly

8008c48

Refs #7497

char0n mentioned this issue

fix(highlight-code): handle mousewheel events properly #7554

Merged

17 tasks

Member

char0n commented Oct 12, 2021

There was a regression, we'll dealing with it in #7554

char0n reopened this

char0n added a commit that referenced this issue


          fix(highlight-code): handle mousewheel events properly (#7554)

0fc429f

SyntaxHighlighter component doesn't support ref. We had
to use different approach to finds it's DOM Node using
ref of the root Node of the render tree for HighlightCode
component.

Refs #7497

char0n added a commit that referenced this issue


          fix(highlight-code): handle mousewheel events properly

450e8a6

SyntaxHighlighter component doesn't support ref. We had
to use different approach to finds it's DOM Node using
ref of the root Node of the render tree for HighlightCode
component.

Refs #7497

char0n added a commit that referenced this issue


          refactor(highlight-code): add UNSAFE prefix for lifecycle methods

d35d6f9

Refs #7497

char0n added a commit that referenced this issue


          fix(highlight-code): handle mousewheel events properly

25d3888

SyntaxHighlighter component doesn't support ref. We had
to use different approach to finds it's DOM Node using
ref of the root Node of the render tree for HighlightCode
component.

Refs #7497

char0n added a commit that referenced this issue


          fix(highlight-code): handle mousewheel events properly

da4f70b

SyntaxHighlighter component doesn't support ref. We had
to use different approach to finds it's DOM Node using
ref of the root Node of the render tree for HighlightCode
component.

Refs #7497

Member

char0n commented Oct 12, 2021 •

edited

Tests are not passing after ported in React 17 using it's new APIs. Working on it here: #7379

Member

char0n commented Oct 14, 2021

Fixed on release/4.x branch.

char0n closed this as completed

char0n added a commit that referenced this issue


          refactor(highlight-code): add UNSAFE prefix for lifecycle methods

154f5bd

Refs #7497

char0n added a commit that referenced this issue


          fix(highlight-code): handle mousewheel events properly

93791cf

SyntaxHighlighter component doesn't support ref. We had
to use different approach to finds it's DOM Node using
ref of the root Node of the render tree for HighlightCode
component.

Refs #7497

char0n added a commit that referenced this issue


          refactor(highlight-code): add UNSAFE prefix for lifecycle methods

0045f91

Refs #7497

char0n added a commit that referenced this issue


          fix(highlight-code): handle mousewheel events properly

e34431d

SyntaxHighlighter component doesn't support ref. We had
to use different approach to finds it's DOM Node using
ref of the root Node of the render tree for HighlightCode
component.

Refs #7497

char0n added a commit that referenced this issue


          refactor(highlight-code): add UNSAFE prefix for lifecycle methods

Refs #7497

char0n added a commit that referenced this issue


          fix(highlight-code): handle mousewheel events properly

46b4e5c

SyntaxHighlighter component doesn't support ref. We had
to use different approach to finds it's DOM Node using
ref of the root Node of the render tree for HighlightCode
component.

Refs #7497

tim-lai mentioned this issue

fix(request-snippets): prevent scrolling errors from missing function #7941

Merged

17 tasks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment