Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix DELETE pill's width/alignment is off #7479

Closed
ponelat opened this issue Aug 31, 2021 · 4 comments
Closed

Fix DELETE pill's width/alignment is off #7479

ponelat opened this issue Aug 31, 2021 · 4 comments

Comments

@ponelat
Copy link
Member

ponelat commented Aug 31, 2021

Source: https://twitter.com/avantar/status/1432273563420135424

Describe the bug you're encountering

The DELETE pill is too wide, compared to the others (GET/POST/etc)

To reproduce...

See screenshot

Screenshots

image

Additional context or thoughts

Either increase the other pills or decrease the DELETE pill

@ponelat
Copy link
Member Author

ponelat commented Aug 31, 2021

UI/UX Notes

  • Any method is allowed, not just the common ones. How should long method names be handled?
  • OPTIONS is even longer than DELETE (see screenshot below)

image

@twjasa
Copy link
Contributor

twjasa commented Sep 26, 2021

Hello ,

Did this

image

To me looks okay. Can I create the PR? 😄

@char0n
Copy link
Member

char0n commented Sep 27, 2021

Hi @twjasa,

Yeah looks good. OPTIONS and DELETE http verbs are the longest one currently supported. Go for a PR; looking forward to reviewing it

@twjasa
Copy link
Contributor

twjasa commented Sep 27, 2021

Hello @char0n, thanks!

Here it is: #7527

PD: not sure if this is the only place that needs to changed in order to look justify in any place. I bet it's 😄

@char0n char0n self-assigned this Sep 30, 2021
@char0n char0n closed this as completed in fc7cdb8 Sep 30, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants